404769 - Tweak tab border colors

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P4)

Description

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Once we've got a Txul baseline with the current implementation, the tab border colors should be swapped out for ones specified using rgba(), nsLookAndFeel and friends.

Comment 1

[ronin.achilles]

Are the borders for unselected tabs going to remain at 2px? They look quite jarring. Can't we reduce it to 1px like its for hovered and active tabs?

Comment 2

[Mike Connor [:mconnor]]

Wanted, not blocking, since this seems like a fairly trivial cosmetic bug.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Dão Gottwald [:dao]]

Attachment: updated alltabs-box-overflow-end-bkgnd-animate.png

Comment 5

[Dão Gottwald [:dao]]

The patch contains some serious cleanup (i.e. it's not fairly trivial cosmetic). I didn't plan to do this, but eventually it's all related to each other somehow.

Comment 6

[Dão Gottwald [:dao]]

Attachment: obligatory screenshot: before (top) and after (bottom)

Doesn't show the full impact of the patch, but you should get a brief impression at least.

Comment 7

[Dão Gottwald [:dao]]

We've been using semi-transparent borders (within the images) before, so the current opaque colors are actually an OS integration regression.

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch v2

found a small glitch with a dark OS theme

Comment 9

[Dão Gottwald [:dao]]

Attachment: more screenshots

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 295673 [details] [diff] [review]
patch v2

a=beltzner for 1.9

Comment 11

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/browser/themes/winstripe/browser/browser.css 1.145
mozilla/browser/themes/winstripe/browser/jar.mn 1.64
mozilla/browser/themes/winstripe/browser/tabbrowser/alltabs-box-overflow-end-bkgnd-animate.png 1.3