40486 - Filter UI: Action section is missing descriptive text

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P4)

Description

[laurel]

Using may24 m16 commercial build

refer to mail filter spec:
http://gooey/client/5.0/specs/mail/filters/Filters.html

The filter rules dialog's Action section needs to have descriptive text, current
spec revision 4/19/00 shows it to be:

"When messages match the above criteria perform the following action:"

Comment 1

[scottputterman]

mass moving to M18 and adding nsbeta3 keyword

Comment 2

[Alec Flett]

reassigning my filter bugs to gayatrib..

Comment 3

[Håkan Waara]

Got a fix in my tree for this - taking.

Comment 4

[Gervase Markham [:gerv]]

hwaara - will this do? Could you review, please?

Gerv

Comment 5

[Gervase Markham [:gerv]]

Attachment: Patch - 3 lines

Comment 6

[Gervase Markham [:gerv]]

Re-ccing hwaara. Hwaara - I attached a patch when you weren't looking ;-)

Gerv

Comment 7

[Gervase Markham [:gerv]]

Attachment: Screenshot

Comment 8

[Håkan Waara]

Thanks for fixing this. r=hwaara

Comment 9

[(not reading, please use [e-mail] instead)]

thanks for working on this.  your wording doesn't match the spec.

http://www.mozilla.org/mailnews/specs/filters/

Comment 10

[Håkan Waara]

What Seth said. Just replace "criteria" with "conditions" and you're done.

Comment 11

[Gervase Markham [:gerv]]

It's nice to have an accessible URL for the spec at last. Silly me for looking
at the bug instead of hunting it down ;-)

Seriously, another patch coming right up.

Gerv

Comment 12

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Comment 13

[(not reading, please use [e-mail] instead)]

sr=sspitzer

note:  you might not need to do orient="vertical".   I think the titlebox should
orient that way by default.

Comment 14

[Håkan Waara]

my r= persists. gerv, do you want me to check this in for you?

Comment 15

[Gervase Markham [:gerv]]

Sure. If you want to check out whether seth is correct and modify the patch 
accordingly, feel free :-) I'm currently in the wrong OS, and in the middle of 
some Distributed Systems revision ;-)

Gerv

Comment 16

[Gervase Markham [:gerv]]

I checked - orient=vertical is necessary. The default for <titlebox> is
horizontal.

Checked in by hwaara. Marking fixed.

Gerv

Comment 17

[(not reading, please use [e-mail] instead)]

thanks for checking about the default for orientation before checking in.

(perhaps it is box that is vertical by default?)

Comment 18

[laurel]

OK using may17 commercial trunk build