405072 - Resizer shouldn't be its own toolbar item

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[MechCommanderRei]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b1) Gecko/2007110904 Firefox/3.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b1) Gecko/2007110904 Firefox/3.0b1

The Resizer toolbar item only works properly when placed alone between the Address and Search fields.  In any case where it's next to a button, using it can wreak havoc on button widths toolbar-wide; Icons get squished or padded, and aren't easily returned to default width.

If the Resizer's only purpose* is to resize the Search field, and indeed it makes trouble when put anywhere else, then it should just be attached to the Search field.  I propose borrowing the resizing code from the Searchbar Autosizer extension, if its author allows it.  There's a step in its Configuration Assistant that lets you freely resize the Search field, and it doesn't squish/stretch your toolbar buttons in the process.

http://searchbarautosizer.mozdev.org/

*: Even if there are items besides the Search field that might benefit from resizability (ex. Flexible Spaces), they are the exceptions.  IMO it's better to make them intrinsically resizable on a case-by-case basis, rather than having a standalone Resizer that's useless or harmful in most positions.

(I also think the Search field should only be resizable in Customize Toolbar mode, but that's a smaller, separate issue.)

Reproducible: Always

Steps to Reproduce:
1. View -> Toolbars -> Customize...
2. Place the Resizer next to a toolbar button (or vice versa) on the toolbar.
3. Close the Customize window, and drag the Resizer around until it starts squishing/stretching toolbar buttons.
Actual Results:  
Various toolbar icons get squished or padded, and are difficult to return to default width.

Expected Results:  
Toolbar button widths should not be affected by the Resizer, which in turn should not be independent from the Search field.

Comment 1

[Neil Deakin]

The resizer has been changed in recent builds to just appear in between the location and search fields always.

Comment 2

[RenegadeX]

MechCommanderRei, see Bug 403959