Closed Bug 405125 Opened 18 years ago Closed 18 years ago

Unified toolbar looks bizarre in windows without toolbars

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 402654

People

(Reporter: bzbarsky, Assigned: jaas)

References

Details

(Keywords: regression)

STEPS TO REPRODUCE: 1) Start trunk firefox 2) View source of any page ACTUAL RESULTS: titlebar sort of washes into the white content area, with no clear separating line between them. Very odd visual effect. EXPECTED RESULTS: Probably a 1px black or darker gray line separating the two. There's a similar effect with the About window (the window background doesn't match the titlebar color), the preferences window (background is striped and doesn't match titlebar color), etc. But those cases are a little easier to fix, maybe: change the background. That's not really an option with the view-source window. In any case, I would expect that windows without a toolbar don't do unified toolbar stuff...
Blocks: 303110
Flags: blocking1.9?
Keywords: regression
Interestingly, the download manager does seem to have a bit of a groove below the titlebar.
Pretty sure this is a dupe, though I can't find the bug. Themes should not be doing this if they don't want the appearance. Though there is a bug to restrict which windows that this applies to, or at least talk on IRC. The DM thing is something else, for some reason it's drawing a line at the top of the window on its own. Think that's filed too?
Component: Widget: Mac → Widget: Cocoa
QA Contact: mac → cocoa
Bug 402654 - dunno if that's a "wallpaper over a core issue for Fx only" bug, or *the* bug that this is a dupe of, though.
fwiw, mconnor and I are blocking on 402654, which is in our opinion the right way to fix this.
In bug 401793 I fixed so non-top level windows don't get the unified toolbar style. There was concensus in #macdev at that point that the unified look should be opt-in rather than applied to all top-level windows by default. Cbarrett said he'd file a bug, but maybe never did? In my opinion, making it opt-in is a better resolution than bug 402654 because non-unified windows would look normal with a real titlebar, as in other OS X apps.
Should we mark this a dup of bug 402654?
Good idea, thanks schrep.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.