Closed Bug 405127 Opened 17 years ago Closed 17 years ago

[Task Mode] Add 'click here to add a new task' feature

Categories

(Calendar :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: michael.buettner, Assigned: michael.buettner)

Details

Attachments

(1 file, 1 obsolete file)

This is a spin-off bug from bug 253396 where the initial step towards the task mode has been implemented. This bug is dedicated to the quick-add feature (i.e. 'click here to add a new task'). In essence this boils down to an edit field above the new task view where users can quickly add a series of tasks, see [1] for details.

[1] http://wiki.mozilla.org/Calendar:Task_Mode
Attached patch patch v1 (obsolete) — Splinter Review
This patch should do the trick...
Attachment #289944 - Flags: ui-review?(christian.jansen)
Attachment #289944 - Flags: review?(Berend.Cornelius)
The patch works pretty fine. Please find the list of small issues below:

- Move the icon into the text field (like the Search Field)
- If possible draw the border of the box flat
- Change the capitalization from "Click here to add a task" to "Click Here to Add a New Task"
- Set the "Start date" to "Today"
- Set the "Due date" to "Today"
- Mark tasks not as "All Day"
- The Title of a selected Task should be not displayed in the text field
   (Create a 2 new tasks, select the first one -> task title is displayed in field)
Comment on attachment 289944 [details] [diff] [review]
patch v1
Attachment #289944 - Flags: review?(Berend.Cornelius) → review+
The patch works fine for me and I have nothing to object.
I am just asking myself if it would not make sens to include the code for the "taskEdit-Control" within the binding of "calendar-task-tree", so that it would automatically also be included within the today pane's task view. I realize that looking at http://wiki.mozilla.org/Calendar:Improving_the_Calendar_Views
there are some subtle differences between both views. The major difference seems to be that in one view the task-edit control is above the task-tree whereas on the other one it is below it. Maybe Christian will want to consolidate that.
regarding the image my opinion is that we should abandon it. As it is just a copy of the "new task" toolbarbutton" that can be found right above the image again it appears rather confusing to me.
Attached patch patch v2Splinter Review
> if it would not make sens to include the code for the
> "taskEdit-Control" within the binding of "calendar-task-tree"
IMHO both elements have nothing in common besides the fact that they'll probably occur in the today pane as well as in the task mode. Bindings should be used to encapsulate reusable controls but not to encapsulate class-like logic. The latter should be achieved by using overlays.

> regarding the image my opinion is that we should abandon it
I totally agree, I also didn't find that the image makes any sense. I removed it from this version of the patch.

> If possible draw the border of the box flat
This depends on the theme. On WinXP/SP2 the border is already flat, on Mac the border has a sunken/raised style. We should probably leave that as it is.

> Change the capitalization...
Done.

> Set the "Start date" to "Today"
> Set the "Due date" to "Today"
I didn't change this I remember that we once agreed that the task list should be just a plain list of 'things that should be done'. Are you sure we should assign dates to entry/due?

> Mark tasks not as "All Day"
Must be a build related problem, new tasks don't get an entry/due date. I tested the behavior on WinXP/SP2 and on a Mac machine.

> The Title of a selected Task should be not displayed...
Once a new task has been created the content of the text field gets erased.

There are just minor code changes, carrying forward r+...
Attachment #289944 - Attachment is obsolete: true
Attachment #290383 - Flags: ui-review?(christian.jansen)
Attachment #290383 - Flags: review+
Attachment #289944 - Flags: ui-review?(christian.jansen)
(In reply to comment #2)
> - Set the "Start date" to "Today"
> - Set the "Due date" to "Today"

I'm pretty sure that I wouldn't want the due date to be automatically set.  If I take the time to add a task to Lightning, it means that I don't have time to work on the task right now, and it's very possible that I won't complete it today.  If I add several of these unfinished tasks today, then tomorrow I could easily have several overdue tasks in my today pane, highlighted in red.  I understand that it could be a time-saver in some cases, but IMO I agree that this is not desirable.

Regarding the start date, I don't know if it should be automatically set to today.  It depends on how the task list in the today pane is going to behave (e.g. does it show tasks without a start date?  does it show tasks with start/due dates in the past, etc.), and unfortunately I don't think that questions like these have been answered yet.

There are several comments in several bugs where people have asked for answers to these questions (most recently in bug 405459 comment 9).  I hope that the calendar team will address this, otherwise I think that you're wasting a lot of effort.  Design/Code/Test, not Code/Test/Design.  :)
Attachment #290383 - Flags: ui-review?(christian.jansen) → ui-review+
patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Version: Trunk → unspecified
Issue: If you move the splitter below the task list to the top the edit field shrinks to a few pixel height. I see no way to restore the correct height therefore the edit field can't be used anymore. 

There probably should be a min-height set to the edit field and the task list, similar to the unifinder.
Verified with Lt 2007120104
Status: RESOLVED → VERIFIED
I filed Bug 407808 for the issue mentioned in Comment #9.
You need to log in before you can comment on or make changes to this bug.