Closed
Bug 405181
Opened 17 years ago
Closed 17 years ago
nsIDOMNSRange.isPointInRange probably shouldn't throw WRONG_DOCUMENT_ERR
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta2
People
(Reporter: WeirdAl, Assigned: WeirdAl)
References
()
Details
Attachments
(1 file)
1.10 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
sicking
:
approval1.9+
|
Details | Diff | Splinter Review |
I don't think I was counting on isPointInRange throwing NS_ERROR_DOM_WRONG_DOCUMENT_ERR when I wrote the patch for bug 359046. The check-in comment indicates otherwise... Jonas, can we just eat that exception and return false?
Yeah, that seems fine to me.
Assignee | ||
Comment 2•17 years ago
|
||
Assignee: nobody → ajvincent
Status: NEW → ASSIGNED
Attachment #290343 -
Flags: superreview?(jonas)
Attachment #290343 -
Flags: review?(jonas)
Attachment #290343 -
Flags: superreview?(jonas)
Attachment #290343 -
Flags: superreview+
Attachment #290343 -
Flags: review?(jonas)
Attachment #290343 -
Flags: review+
Attachment #290343 -
Flags: approval1.9+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Comment 3•17 years ago
|
||
Checking in content/base/src/nsRange.cpp; /cvsroot/mozilla/content/base/src/nsRange.cpp,v <-- nsRange.cpp new revision: 1.225; previous revision: 1.224 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
Updated•11 years ago
|
Component: DOM: Traversal-Range → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•