Closed Bug 405282 Opened 15 years ago Closed 15 years ago

Test for bug 382990 leaves bookmarks sidebar open

Categories

(Toolkit :: XUL Widgets, defect)

Product:
Toolkit
Component:
XUL Widgets
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

This ctrl+b makes you open, and this one makes you close
1.07 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
Apparently no tests we have yet (that run after it) care, but it's a little disconcerting to see the bug 382990 test open the bookmarks sidebar when the tree it sends a ctrl+b successfully ignores that keypress, and lets the menu shortcut handle it instead. And since it doesn't open the sidebar on OS X, when someone comes along later with a test that expects it to be closed, that works fine on their Mac, they'll be in for a big surprise when they fail on Windows and Linux.
Attachment #290080 - Flags: review?(gavin.sharp)
Attachment #290080 - Flags: review?(gavin.sharp) → review+
toolkit/content/tests/widgets/test_bug382990.xul 1.2
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.