405320 - Support "out of order" multiple word tag search in url bar autocomplete

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

support "out of order" multiple word tag search in the url bar and in the places organizer.

in bug #401869, [e-mail] writes:

"aren't we going to allow random ordering of words? i.e. if a user has a tag called "read later"... will he not be able to search on "read later" as well as "later read"?

right now, this doesn't work.  

note, one way we could implement this would be to change                                                                               nsNavHistory::CreateTermsFromTokens() to generate all the permutations, and not just the "in order" ones.  

that would lower our "limit" (caused by SQLITE_MAX_EXPR_DEPTH), but that might be acceptable.

Comment 1

[Ed Lee :Mardak]

The autocomplete results part will be fixed by bug 401660.

Comment 2

[Ed Lee :Mardak]

Attachment: testcase v1

I'll land this testcase when bug 401660 is fixed.

Comment 3

[Ed Lee :Mardak]

Should I spin off a separate bug for library/places organizer searching if bug 401660 lands and mark this fixed?

Comment 4

[Ed Lee :Mardak]

Checking in toolkit/components/places/tests/unit/test_history_autocomplete_tags.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_history_autocomplete_tags.js,v  <--  test_history_autocomplete_tags.js
new revision: 1.4; previous revision: 1.3
done

Comment 5

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre and the same nightly on Win XP