405372 - jsshell tracing() appears to work in JS_THREADED_INTERP builds but doesn't

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Print an error message when JS_THREADED_INTERP

Comment 1

[Brendan Eich [:brendan]]

Comment on attachment 290170 [details] [diff] [review]
Print an error message when JS_THREADED_INTERP

>Index: js.c
>===================================================================
>RCS file: /cvsroot/mozilla/js/src/js.c,v
>retrieving revision 3.176
>diff -p -u -8 -r3.176 js.c
>--- js.c	19 Nov 2007 17:15:45 -0000	3.176
>+++ js.c	26 Nov 2007 02:23:22 -0000
>@@ -1443,16 +1443,20 @@ DisassWithSrc(JSContext *cx, JSObject *o
> }
> 
> static JSBool
> Tracing(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
> {
>     JSBool bval;
>     JSString *str;
> 
>+#if JS_THREADED_INTERP
>+    fprintf(gErrFile,
>+            "tracing not supported in builds with JS_THREADED_INTERP\n");

Why not JS_ReportError and return false?

Also, nit: "tracing not supported in JS_THREADED_INTERP builds".

/be

Comment 2

[Jeff Walden [:Waldo]]

I was following the choice a few lines above the #endif in the patch, which printed and returned true.  I guess I'll change that in the next patch, too...

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Report error, fail when not supported/invalid argument

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 290179 [details] [diff] [review]
Report error, fail when not supported/invalid argument

Remove the \n from that string and r+a=me.

/be

Comment 5

[Jeff Walden [:Waldo]]

Fixed, with \n removed from the reported errors.