Closed Bug 405376 Opened 17 years ago Closed 15 years ago

"Current Window" option in Open Web Location window should be named "Current Tab"

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: adelfino, Assigned: tdowner)

Details

(Keywords: polish, Whiteboard: [polish-easy])

Attachments

(1 file)

Patch v1
1.59 KB, patch
robert.strong.bugs
: review+
jboriss
: ui-review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112505 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112505 Minefield/3.0b2pre

Since the location will open in the current window if it is opened in the current tab (Current Window) or in a new one (New Tab), Firefox should make this clear.

Reproducible: Always
Version: unspecified → Trunk
Flags: blocking-firefox3?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
OS: Windows XP → All
Hardware: PC → All
Nominating for blocking‑firefox3.1 now that we have some time.
Flags: blocking-firefox3.1?
Whoops. Slipped off the radar :( We're past string freeze, but that's no reason not to fix it on trunk :)
Flags: blocking-firefox3.1? → blocking-firefox3.1-
Keywords: polish
Whiteboard: [polish-easy]
Selecting File > Open Location currently just focuses the location bar, I don't think this window exists anymore, but I could very well be wrong.  Please reopen if this is still an issue.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
Status: RESOLVED → VERIFIED
(In reply to comment #3)
> Selecting File > Open Location currently just focuses the location bar, I don't
> think this window exists anymore, but I could very well be wrong.  Please
> reopen if this is still an issue.

This happens when navigation toolbar is hidden. Reopening.
Status: VERIFIED → REOPENED
Resolution: INVALID → ---
OK, http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/openLocation.dtd is what we are talking about right?
Assignee: nobody → tyler.downer
Status: REOPENED → ASSIGNED
(In reply to comment #5)
> OK,
> http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/openLocation.dtd
> is what we are talking about right?

Exactly.
Attached patch Patch v1 — — Splinter Review 
OK, then I think this does it.
Attachment #389798 - Flags: ui-review?
Comment on attachment 389798 [details] [diff] [review]
Patch v1

Wrong e-mail in the review. Faaborg, need a UI review, then a regular review, correct?
Attachment #389798 - Flags: ui-review? → ui-review?(faaborg)
Comment on attachment 389798 [details] [diff] [review]
Patch v1

giving ui+ while faaborg is ooto: patch looks good
Attachment #389798 - Flags: ui-review?(faaborg) → ui-review+
Attachment #389798 - Flags: review?(robert.bugzilla)
Comment on attachment 389798 [details] [diff] [review]
Patch v1

Looks good and thanks
Attachment #389798 - Flags: review?(robert.bugzilla) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/225d454e3903
Status: ASSIGNED → RESOLVED
Closed: 16 years ago → 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
V. Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090731 Minefield/3.6a1pre (.NET CLR 3.5.30729) ID:20090731044744
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: