DeleteSignon() in toolkit/components/passwordmgr/content/passwordManager.js looks suspicious to me. The list it's deleting from is specified by: |signonsTreeView._filterSet.length ? signonsTreeView._filterSet : signons|
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: PC → All
Version: unspecified → Trunk
Regression from bug 327048. Taking over...
Assignee: nobody → ehsan.akhgari
Target Milestone: --- → Firefox 3 M11
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Created attachment 292322 [details] [diff] [review] Patch (v1) The code at <http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/components/passwordmgr/content/passwordManager.js&rev=1.18&mark=121#119> can't be touched, because of the way that the |DeleteSelectedItemFromTree()| function works. The problem is caused by the fact that if passwords are deleted from a filtered view, the deletions are not made in the original (non-filtered) |signons| table, so when an action on that original table is performed next (such as, clicking Show Passwords) the deleted entries re-appear. The proposed solution is to reload the |signons| table in |FinalizeSignonDeletions()| if the deletions are performed in a filtered view, so that the two tables stay in sync. This patch implements the mentioned solution. It's been tested, and the test case in the comment 0 cannot be reproduced on a trunk build with this patch.
Attachment #292322 - Flags: review?(mconnor)
Attachment #292322 - Flags: review?(mconnor) → review+
Checking in toolkit/components/passwordmgr/content/passwordManager.js; /cvsroot/mozilla/toolkit/components/passwordmgr/content/passwordManager.js,v <-- passwordManager.js new revision: 1.19; previous revision: 1.18 done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Summary: Passwords reappear after being deleted, when using the search. → Passwords reappear after being deleted, when using the search
verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042504 Minefield/3.0pre. https://litmus.mozilla.org/show_test.cgi?id=5294 added to litmus.
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.