405470 - forceHandshake should be removed

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

48     attribute boolean                   forceHandshake; /* obsolete, unused */

The comment is correct, so the attribute should be removed. (The implementation of it doesn't do anything - the getter always returns false, the setter does nothing)

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: Patch

also removes some other unused stuff

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 290281 [details] [diff] [review]
Patch

I'll include these changes in bug 262116's patch

Comment 3

[Kai Engert (:KaiE:)]

Comment on attachment 290281 [details] [diff] [review]
Patch

I confirm this doesn't seem to be used anywhere.

r=kengert

Comment 4

[Kai Engert (:KaiE:)]

Christian, did you check in this patch together with bug 262116?
Should this be marked fixed?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

indeed, thanks.