405521 - Empty batch update notifications sent to nsINavBookmarkObserver

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Adam Kowalczyk]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112605 Minefield/3.0b2pre

Whenever bookmarks are added, removed, or moved, bookmark observer receives a pair of onBeginUpdateBatch...onEndUpdateBatch notifications with nothing in between.

For instance, here's the sequence of notifications for removing a bookmark:

onItemChanged
onBeginUpdateBatch
onEndUpdateBatch 
onItemRemoved

Comment 1

[Marco Bonardo [:mak]]

this is (likely) caused by adjustIndices, see also Bug 405551, there is a batch call that has not been removed between 1.51 and 1.52. Will probably be fixed in Bug 405551 

Comment 2

[Marco Bonardo [:mak]]

still valid, the fix for Bug 405551 did not touch that code, it appears to be necessary for observers in debug mode. Must be investigated

Comment 3

[Adam Kowalczyk]

Not blocking but wanted, I think. It doesn't affect end-users directly but it certainly affects extension developers. Nominating.

Comment 4

[Mike Connor [:mconnor]]

yeah, wanted.

Comment 5

[Adam Kowalczyk]

Fixed by bug 423212.

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv