Closed Bug 405638 Opened 15 years ago Closed 15 years ago

Move Show All History to the top of the history list in the menu (bookmarks menu parity)

Categories

(Firefox :: Bookmarks & History, defect, P4)

defect

Tracking

()

VERIFIED FIXED
Firefox 3 beta3

People

(Reporter: jmjjeffery, Assigned: florian)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007112705 Minefield/3.0b2pre Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007112705 Minefield/3.0b2pre Firefox/3.0

With the change to add 'Show all History' to the History Menu drop list I note the Show all History is displayed at the bottom of the drop-list.  I think it would be better to place this under the 'Home' putting the 'Show all History' in the same relative postion as the 'Show all Bookmarks', in the Bookmarks Menu drop-list. 

There is also no keyboard 'short-cut' to open the History Organizer.  
I understand that shortcuts are sometimes hard to come by without causing conflicts, so I have no suggestions.  

Reproducible: Always

Steps to Reproduce:
1.
2.
3.



Vista HP, latest nightly build:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007112705 Minefield/3.0b2pre Firefox/3.0 ID:2007112705
Version: unspecified → Trunk
IMO Ctrl+Shift+H can be mapped for "Show all History".
Component: History → Places
QA Contact: history → places
Summary: Show All History in wrong position in drop list → Move Show All History to the top of the history list in the menu (bookmarks menu parity)
Component: Places → History
Keywords: uiwanted
Flags: blocking-firefox3?
QA Contact: places → history
except on Mac, since that's the sidebar (Cmd+H is Hide on Mac)
Assignee: nobody → florian
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Target Milestone: --- → Firefox 3 M11
Flags: wanted-firefox3+
Flags: blocking-firefox3-
Flags: blocking-firefox3+
Priority: P2 → P4
The "Show All History..." item looks at lot like a "Show more" button and then displaying it at the bottom of the list makes sense.  What about moving the "Show All Bookmarks..." item to the bottom of the bookmarks list?
(In reply to comment #3)
> The "Show All History..." item looks at lot like a "Show more" button and then
> displaying it at the bottom of the list makes sense.  What about moving the
> "Show All Bookmarks..." item to the bottom of the bookmarks list?
> 

The problem displaying "Show All Bookmarks" at the bottom is not too practical since if a user has a long list of bookmarks, he'd have to scroll all the way down too reach it. Hence its current location is just fine where all the fixed commands are at the top while the list of bookmarks itself (which could be of variable length) follows from there.
(In reply to comment #4)
> if a user has a long list of bookmarks, he'd have to scroll all the way
> down too reach it.

Huh, yeah that would be bad.  I thought the menu was only displaying the first bookmarks.
Attached patch patch v1Splinter Review
Move the "Show All History..." item and add the Ctrl+shift+H keybinding except on Mac. It would be good to add another key for the Mac case.

With non-english languages Hide and History will probably start with different letters so the problem we have on Mac will not exist (and the reason why this patch doesn't add the key on Mac will be obscure).
Attachment #292174 - Flags: ui-review?(mconnor)
Whiteboard: [needs ui-r]
Comment on attachment 292174 [details] [diff] [review]
patch v1

Looks good, r+ui-r+a=mconnor, trivial and straightforward
Attachment #292174 - Flags: ui-review?(mconnor)
Attachment #292174 - Flags: ui-review+
Attachment #292174 - Flags: review+
Attachment #292174 - Flags: approval1.9+
Florian has commit access, so he can commit his own patches. :)
OS: Windows Vista → All
Hardware: PC → All
Whiteboard: [needs ui-r] → [has patch][has review][has ui-review][has approval][ready to land]
Checking in browser/base/content/browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.108; previous revision: 1.107
done
Checking in browser/base/content/browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <--  browser-menubar.inc
new revision: 1.126; previous revision: 1.125
done
Checking in browser/locales/en-US/chrome/browser/browser.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.dtd,v  <--  browser.dtd
new revision: 1.85; previous revision: 1.84
done
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][has ui-review][has approval][ready to land]
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre and on the latest Mac nightly. I verified both the position and the functionality of the keyboard shortcut on Windows.
Status: RESOLVED → VERIFIED
Component: History → Bookmarks & History
QA Contact: history → bookmarks
You need to log in before you can comment on or make changes to this bug.