Closed Bug 405664 Opened 17 years ago Closed 17 years ago

keyboard shortcut to display the search engine list broken (alt+up/down, f4)

Categories

(Firefox :: Search, defect, P1)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3 beta2

People

(Reporter: kbrosnan, Assigned: Gavin)

Details

(Keywords: access, regression)

Attachments

(1 file)

patch
5.50 KB, patch
enndeakin
: review+
mtschrep
: approval1.9+
Details | Diff | Splinter Review 
F4 should display the list of installed search engines. On the trunk this fails to work.
Flags: blocking-firefox3?
This is a regression between beta 1 and 2007112704. I'll try and narrow it some more latter tonight.
OS: Linux → All
Hardware: PC → All
Summary: keyboard shortcut to display the search engine list broken f4 → keyboard shortcut to display the search engine list broken (alt+up/down, f4)
Attached patch patch — — Splinter Review 
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED

        Attachment #290753 -
        Flags: review?(enndeakin)
Priority: -- → P1
Target Milestone: --- → Firefox 3 M10

    
    

    
  
Comment on attachment 290753 [details] [diff] [review]
patch

Looks ok, is there a reason why the searchbox isn't just a menu to avoid reimplementing the key handling?

        Attachment #290753 -
        Flags: review?(enndeakin) → review+

    
    

    
  
Comment on attachment 290753 [details] [diff] [review]
patch

Pretty important accessibility regression, low-risk fix.

        Attachment #290753 -
        Flags: approval1.9?

    
  

        Attachment #290753 -
        Flags: approval1.9? → approval1.9+

    
    

    
  
mozilla/browser/components/search/Makefile.in 	1.9
mozilla/browser/components/search/content/search.xml 	1.112
mozilla/browser/components/search/test/Makefile.in 	1.1
mozilla/browser/components/search/test/browser_405664.js 	1.1 
Keywords: checkin-needed

    
    

    
  
Can this be resolved as fixed since the patch landed?
Flags: blocking-firefox3? → blocking-firefox3+

    
    

    
  
Fixed - Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120405 Minefield/3.0b2pre
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
Er, yeah, thought I'd marked it fixed. Oops.

    
    

    
  
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120405 Minefield/3.0b2pre. alt+up/down, f4 all work.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: