405674 - [10.5] Changing System Pref keyboard shortcuts for All Applications leads to toolbar menu names being replaced with "SomeMenuItem" across the board

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P4)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b2pre) Gecko/2007112304 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b2pre) Gecko/2007112304 Minefield/3.0b2pre

I was making changes in the system preferences trying to add a shortcut to Terminal, and when I set the shortcut and came back to Minefield, the toolbar menu was full of "SomeMenuItem" - the pulldowns still contained the correct information for what should have been File, Edit...etc

Restarting brought back the correct toolbars, and I was able to reproduce.

Reproducible: Always

Steps to Reproduce:
1. Have Minefield open, I had a couple of tabs open too
2. Open System Preference->Keyboard & Mouse
3. Click on "+" to add a new shortcut
4. Leave it's default as "All Applications"
5. Enter any name, and then as the keyboard shortcut enter ctrl + option + command + T  (at the same time so that the keyboard shortcut shows up in the keyboard shortcut window
6. Click "Add"
7. Go back to Minefield - you should see all your menus being called "SomeMenuItem"
Actual Results:  
see attached

Expected Results:  
That the menu names would not change.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: The keyboard shortcut adding window

This is the window where keyboard shortcuts are entered

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Results of "SomeMenuItem" as menu names

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Confirming in today's Minefield on 10.5.1.  I see the original menu titles for a fraction of a second when switching back to Minefield from System Prefs, and then they all flash to "SomeMenuItem".

Similarly, deleting the shortcut I just added also causes this (if I've restarted Minefield since adding the shortcut).

All that's necessary to get the correct menus back is to restart the app (not the whole OS), in my case.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

To be clear, when I said restarting - I meant Firefox, not the OS.

Comment 5

[Phil Ringnalda (:philor)]

Looks to be 10.5-only, I can't reproduce on 10.4.11.

Comment 6

[Chris Lawson (gone)]

I can't repro on 10.4.11 either with Minefield 2007112704, so it's probably safe to call this 10.5-only.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

It would not surprise me if this were related to the extra-Minefield menu bug, which would be a reason for this to be 10.5-only (or it could just be another fun 10.5 bug!).

Comment 8

[Josh Aas]

I don't think this is related to the extra menu bug.

Comment 9

[Colin Barrett [:cbarrett]]

Attachment: fix v1.0

This fixes it on my end, though I did not try anything fancy.

It looks like when you set that shortcut, the title of the menu item, and not the title of the submenu, is getting displayed. Should probably go on "list of things to try in a test app and file as a radar".

Comment 10

[Colin Barrett [:cbarrett]]

Attachment: fix v1.1

address IRC review comments

Comment 11

[Josh Aas]

landed on trunk

Comment 12

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O 10.5; en-US; rv:1.9b2pre) Gecko/2007120404 Minefield/3.0b2pre. Verified following the steps on Comment 0.