Closed
Bug 405687
Opened 17 years ago
Closed 16 years ago
missing keyboard shortcut for the tasks window
Categories
(Calendar :: Lightning Only, enhancement)
Calendar
Lightning Only
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: maxxmozilla, Assigned: maxxmozilla)
Details
Attachments
(1 file, 1 obsolete file)
3.22 KB,
patch
|
berend.cornelius09
:
review+
chris.j.bugzilla
:
ui-review+
|
Details | Diff | Splinter Review |
Tested on Lightning 0.8pre (build 2007112706) Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 ID:2007103104
Attachment #290450 -
Flags: review?(jminta)
Comment 1•17 years ago
|
||
Comment on attachment 290450 [details] [diff] [review] Assigns accel+4 to the switch2task command I am no longer a calendar peer.
Attachment #290450 -
Flags: review?(jminta) → review?(mvl)
Updated•17 years ago
|
Attachment #290450 -
Flags: ui-review?(christian.jansen)
Attachment #290450 -
Flags: review?(mvl)
Attachment #290450 -
Flags: review?(Berend.Cornelius)
Comment 2•17 years ago
|
||
Comment on attachment 290450 [details] [diff] [review] Assigns accel+4 to the switch2task command r=christian
Attachment #290450 -
Flags: ui-review?(christian.jansen) → ui-review+
Comment 3•17 years ago
|
||
IMO we should also add a "task mode" menu item to the "Go" menu in Calendar mode (including accel+4 as key).
OS: Windows 2000 → All
Hardware: PC → All
Assignee | ||
Comment 4•17 years ago
|
||
Thanks for the notice, I will update the patch after updating my cvs tree.
Assignee | ||
Comment 5•17 years ago
|
||
Tested on Lightning 0.8pre (build 2007122903) Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 ID:2007103104 I'm not sure if I can carry over ui-review+ so re-requesting. BTW I would prefer accel+1, 2, 3 for mail, calendar and tasks respectively but we rather can't change TB defaults... (e.g. those using shortcuts can by mistake switch themselves to the address book and there only accel+1 works (switches to the last view and not mail directly ?) - this will need probably another bug).
Attachment #290450 -
Attachment is obsolete: true
Attachment #294852 -
Flags: ui-review?(christian.jansen)
Attachment #294852 -
Flags: review?(Berend.Cornelius)
Attachment #290450 -
Flags: review?(Berend.Cornelius)
Comment 6•16 years ago
|
||
Comment on attachment 294852 [details] [diff] [review] Adds also missing "Tasks" to the "Go" menu in calendar mode r=christian
Attachment #294852 -
Flags: ui-review?(christian.jansen) → ui-review+
Comment 7•16 years ago
|
||
Comment on attachment 294852 [details] [diff] [review] Adds also missing "Tasks" to the "Go" menu in calendar mode Your patch integrates well into the existing implementation and seems to work faultless. Thank you!
Attachment #294852 -
Flags: review?(Berend.Cornelius) → review+
Updated•16 years ago
|
Keywords: checkin-needed
Comment 8•16 years ago
|
||
Patch checked in on HEAD and MOZILLA_1_8_BRANCH.
Updated•16 years ago
|
Target Milestone: --- → 0.8
Assignee | ||
Comment 9•16 years ago
|
||
Thanks for reviews and the checkin. Verified with build 2008010904 on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.9) Gecko/20071031 Lightning/0.8pre Thunderbird/2.0.0.9 ID:2007103104
You need to log in
before you can comment on or make changes to this bug.
Description
•