missing keyboard shortcut for the tasks window

VERIFIED FIXED in 0.8

Status

Calendar
Lightning Only
--
enhancement
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: Przemyslaw Bialik, Assigned: Przemyslaw Bialik)

Tracking

unspecified

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Created attachment 290450 [details] [diff] [review]
Assigns accel+4 to the switch2task command

Tested on Lightning 0.8pre (build 2007112706)
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 ID:2007103104
Attachment #290450 - Flags: review?(jminta)

Comment 1

11 years ago
Comment on attachment 290450 [details] [diff] [review]
Assigns accel+4 to the switch2task command

I am no longer a calendar peer.
Attachment #290450 - Flags: review?(jminta) → review?(mvl)
Attachment #290450 - Flags: ui-review?(christian.jansen)
Attachment #290450 - Flags: review?(mvl)
Attachment #290450 - Flags: review?(Berend.Cornelius)

Comment 2

11 years ago
Comment on attachment 290450 [details] [diff] [review]
Assigns accel+4 to the switch2task command

r=christian
Attachment #290450 - Flags: ui-review?(christian.jansen) → ui-review+
IMO we should also add a "task mode" menu item to the "Go" menu in Calendar mode (including accel+4 as key).
OS: Windows 2000 → All
Hardware: PC → All
(Assignee)

Comment 4

11 years ago
Thanks for the notice, I will update the patch after updating my cvs tree.
(Assignee)

Comment 5

11 years ago
Created attachment 294852 [details] [diff] [review]
Adds also missing "Tasks" to the "Go" menu in calendar mode

Tested on Lightning 0.8pre (build 2007122903)
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.9) Gecko/20071031
Thunderbird/2.0.0.9 ID:2007103104

I'm not sure if I can carry over ui-review+ so re-requesting.

BTW I would prefer accel+1, 2, 3 for mail, calendar and tasks respectively but we rather can't change TB defaults... (e.g. those using shortcuts can by mistake switch themselves to the address book and there only accel+1 works (switches to the last view and not mail directly ?) - this will need probably another bug).
Attachment #290450 - Attachment is obsolete: true
Attachment #294852 - Flags: ui-review?(christian.jansen)
Attachment #294852 - Flags: review?(Berend.Cornelius)
Attachment #290450 - Flags: review?(Berend.Cornelius)

Comment 6

11 years ago
Comment on attachment 294852 [details] [diff] [review]
Adds also missing "Tasks" to the "Go" menu in calendar mode

r=christian
Attachment #294852 - Flags: ui-review?(christian.jansen) → ui-review+

Comment 7

10 years ago
Comment on attachment 294852 [details] [diff] [review]
Adds also missing "Tasks" to the "Go" menu in calendar mode

Your patch integrates well into the existing implementation and seems to work faultless. Thank you!
Attachment #294852 - Flags: review?(Berend.Cornelius) → review+

Updated

10 years ago
Keywords: checkin-needed

Comment 8

10 years ago
Patch checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 0.8
(Assignee)

Comment 9

10 years ago
Thanks for reviews and the checkin.

Verified with build 2008010904 on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.9) Gecko/20071031 Lightning/0.8pre Thunderbird/2.0.0.9 ID:2007103104
Verified per comment#9.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.