Closed Bug 405696 Opened 17 years ago Closed 17 years ago

Cmd+F in download manager doesn't work on Mac (should focus the find box)

Categories

(Toolkit :: Downloads API, defect, P3)

Product:
Toolkit
Component:
Downloads API
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9beta2

People

(Reporter: jruderman, Assigned: asaf)

References

Details

Attachments

(1 file)

patch
4.38 KB, patch
mconnor
: review+
Details | Diff | Splinter Review
A few days after bug 404647 was fixed, Stephen Donner and I noticed that the fix didn't work on Mac. It's supposed to make Ctrl+F / Cmd+F focus the download manager's search bar. I suspect that the platform difference is due to the Edit menu, which includes a Find menu item, being shared between the browser window and the download manager. (Split from bug 404647 comment 8 per Mano's request.)
Flags: blocking-firefox3?
Attached patch patch — — Splinter Review
This also fixes bug 405698.
Attachment #290993 - Flags: review?(mconnor)
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [needs review mconnor]
Target Milestone: --- → Firefox 3 M10
Comment on attachment 290993 [details] [diff] [review] patch good catch, thanks!
Attachment #290993 - Flags: review?(mconnor) → review+
Attachment #290993 - Flags: approval1.9?
Whiteboard: [needs review mconnor]
Flags: blocking-firefox3? → blocking-firefox3+
mozilla/browser/base/content/downloadManagerOverlay.xul 1.3 mozilla/toolkit/mozapps/downloads/content/downloads.js 1.109 mozilla/toolkit/mozapps/downloads/content/downloads.xul 1.35
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-litmus?
Attachment #290993 - Flags: approval1.9?
Verified FIXED with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007120304 Minefield/3.0b2pre
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: