Closed Bug 405705 Opened 12 years ago Closed 11 years ago
remove #define MINIMO references
contains fixes for 405702.
Comment on attachment 316864 [details] [diff] [review] Patch 1: basic tree hygine page There's no need for the case *) thing... just set MOZ_EMBEDDING_PROFILE=default
Attachment #316864 - Flags: review?(benjamin) → review-
Attachment #316864 - Flags: superreview?(ted.mielczarek) → superreview+
okay, will fix that on checkin. I was thinking it was boilerplate for the first app that needed to change the profile. benjamin, r=?
Can I see an updated patch?
same as above, but includes a change to configure to make MOZ_EMBEDDING_PROFILE default by default.
Comment on attachment 319020 [details] [diff] [review] basic tree hygine page #2 Why isn't Benjamin getting the sr? here? /be
Attachment #319020 - Flags: superreview?(brendan) → superreview?(benjamin)
i think i asked brendan when benjamin was out on leave. given that it was a tree wide change, I guessed and marked brendan for sr. now that benjamin is back, he is the right sr.
Comment on attachment 319020 [details] [diff] [review] basic tree hygine page #2 Index: toolkit/Makefile.in =================================================================== -ifndef MINIMO DIRS += \ xre \ - mozapps \ - $(NULL) -endif + mozapps \ + $(NULL) Might as well make all the indentation consistent while you're here.
Attachment #319020 - Flags: review?(ted.mielczarek) → review+
Attachment #319020 - Flags: superreview?(benjamin) → superreview+
ted, i updated this patch for mozilla central.
Attachment #325174 - Flags: review? → review+
checked in: 4b3f252de3de
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.