Closed
Bug 405705
Opened 17 years ago
Closed 16 years ago
remove #define MINIMO references.
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: dougt)
References
Details
Attachments
(1 file, 2 obsolete files)
8.15 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•16 years ago
|
||
Assignee | ||
Updated•16 years ago
|
Attachment #316864 -
Flags: superreview?(ted.mielczarek)
Attachment #316864 -
Flags: review?(benjamin)
Assignee | ||
Comment 2•16 years ago
|
||
contains fixes for 405702.
Comment 4•16 years ago
|
||
Comment on attachment 316864 [details] [diff] [review] Patch 1: basic tree hygine page There's no need for the case *) thing... just set MOZ_EMBEDDING_PROFILE=default
Attachment #316864 -
Flags: review?(benjamin) → review-
Updated•16 years ago
|
Attachment #316864 -
Flags: superreview?(ted.mielczarek) → superreview+
Assignee | ||
Comment 5•16 years ago
|
||
okay, will fix that on checkin. I was thinking it was boilerplate for the first app that needed to change the profile. benjamin, r=?
Comment 6•16 years ago
|
||
Can I see an updated patch?
Assignee | ||
Comment 7•16 years ago
|
||
same as above, but includes a change to configure to make MOZ_EMBEDDING_PROFILE default by default.
Attachment #316864 -
Attachment is obsolete: true
Attachment #319020 -
Flags: review?(benjamin)
Assignee | ||
Updated•16 years ago
|
Attachment #319020 -
Flags: superreview?(brendan)
Attachment #319020 -
Flags: review?(ted.mielczarek)
Attachment #319020 -
Flags: review?(benjamin)
Comment 8•16 years ago
|
||
Comment on attachment 319020 [details] [diff] [review] basic tree hygine page #2 Why isn't Benjamin getting the sr? here? /be
Attachment #319020 -
Flags: superreview?(brendan) → superreview?(benjamin)
Assignee | ||
Comment 9•16 years ago
|
||
i think i asked brendan when benjamin was out on leave. given that it was a tree wide change, I guessed and marked brendan for sr. now that benjamin is back, he is the right sr.
Comment 10•16 years ago
|
||
Comment on attachment 319020 [details] [diff] [review] basic tree hygine page #2 Index: toolkit/Makefile.in =================================================================== -ifndef MINIMO DIRS += \ xre \ - mozapps \ - $(NULL) -endif + mozapps \ + $(NULL) Might as well make all the indentation consistent while you're here.
Attachment #319020 -
Flags: review?(ted.mielczarek) → review+
Updated•16 years ago
|
Attachment #319020 -
Flags: superreview?(benjamin) → superreview+
Assignee | ||
Comment 11•16 years ago
|
||
ted, i updated this patch for mozilla central.
Attachment #319020 -
Attachment is obsolete: true
Attachment #325174 -
Flags: review?
Updated•16 years ago
|
Attachment #325174 -
Flags: review? → review+
Assignee | ||
Comment 12•16 years ago
|
||
checked in: 4b3f252de3de
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•