405748 - esc key does not stop animation in animated gifs

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Pressing the esc key does not stop the animation in animated gifs.
(esc key should also stop aPNG, I think)
Spin off from bug 379199 (see bug 379199 comment 5 and bug 379199 comment 26).

Regressed somewhere around April 15 2007. I'll try to find out a better regression range later.

Comment 1

[philippe (part-time)]

so, with the following STR:
1. save above url as .webloc on the desktop
2. load Camino with TroubleShoot Camino.
3. drag url to icon in the dock.

At any moment during page load or after the page has fully loaded, press esc.

works OK 2007041505 (1.2+) 
Fails 2007041605 (1.2+)
Tested with 10.4.11 ppc.
That matches the dates in bug 379199 comment 14

I've also tried with the page bookmarked on the BM bar - same result.

Comment 2

[philippe (part-time)]

On my homemade build, this appears to be fixed by bug 358379.
(need to verify with an official build) 

Comment 3

[philippe (part-time)]

Actually, I was wrong. Some animated images are stopped, some continue to run.
The dino in the url stopped. But most of the other images link form the LH side bar failed the test.

Tested again with both the home made build and the 2.0a1pre (1.9b4pre 2008022903) one.

Comment 4

[Stuart Morgan]

-[BrowserWindow cancel:] is supposed to handle this (and still does if you have something that doesn't eat it focused, but at this point that pretty much means a toolbar button with FKA enabled).

Content can legitimately catch esc (e.g., MODI), so there's nothing we can pre-check to decide whether or not to dispatch into Gecko, which means so far as I can see there is absolutely no way for us to do this outside of Gecko unless bug 379199 is fixed. So it looks like we are stuck with the regression for 2.0.

Comment 5

[John David Galt]

Isn't this a dup of bug 21623?

Comment 6

[Chris Lawson (gone)]

No; this is a Camino-specific regression of a feature that used to work (at least mostly) properly in Camino.

Comment 7

[Stuart Morgan]

Fixed by checkin for bug 519922.

Comment 8

[philippe (part-time)]

The dino now stops on demand :-).
--> Verified with 2.1a1pre (1.9.0.16pre 2009100901)