Looking for saved searches? click on "Search Bugs" above.

1.9 doesn't detect powerpc correctly

RESOLVED FIXED in mozilla1.9beta2

Status

()

Product:
Core
Component:
XPCOM
RESOLVED FIXED
Reported:
10 years ago
Modified:
10 years ago

People

(Reporter: Raúl Porcel, Assigned: Raúl Porcel)

Tracking

Version:
Trunk
Target:
mozilla1.9beta2
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

ppc.patch
880 bytes, patch
timeless
: review+
Benjamin Smedberg
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

•
10 years ago 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.9) Gecko/20071103 Firefox/2.0.0.9
Build Identifier: 

Due to the apply of bug 372428, $OS_TEST on powerpc now returns 'powerpc', and xpcom Makefile expects 'ppc'.

Reproducible: Always
(Assignee)

Comment 1

•
10 years ago 
Created attachment 290526 [details] [diff] [review]
ppc.patch

Patch :)
 (Assignee)

Updated

•
10 years ago
Version: unspecified → Trunk

Comment 2

•
10 years ago 
we ship this patch in ubuntu ... the build succeeds.
Status: UNCONFIRMED → NEW
Ever confirmed: true
 (Assignee)

Updated

•
10 years ago
Attachment #290526 - Flags: review?(timeless)
 (Assignee)

Comment 3

•
10 years ago 
Comment on attachment 290526 [details] [diff] [review]
ppc.patch

Index: xpcom/reflect/xptcall/src/md/unix/Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v
retrieving revision 1.95
diff -u -b -B -u -8 -p -r1.95 Makefile.in
--- xpcom/reflect/xptcall/src/md/unix/Makefile.in	9 Nov 2007 18:53:21 -0000	1.95
+++ xpcom/reflect/xptcall/src/md/unix/Makefile.in	28 Nov 2007 14:32:02 -0000
@@ -273,17 +273,17 @@ endif
 
 # #24617  Building the CPP's (CXX) optimized causes a crash
 CXXFLAGS 	:=  $(filter-out $(MOZ_OPTIMIZE_FLAGS), $(CXXFLAGS))
 endif
 
 #
 # Linux/PPC
 #
-ifeq ($(OS_ARCH)$(OS_TEST),Linuxppc)
+ifeq ($(OS_ARCH)$(OS_TEST),Linuxpowerpc)
 CPPSRCS		:= xptcinvoke_ppc_linux.cpp xptcstubs_ppc_linux.cpp
 ASFILES		:= xptcinvoke_asm_ppc_linux.s xptcstubs_asm_ppc_linux.s
 AS		:= $(CC) -c -x assembler-with-cpp
 endif
 
 #
 # NetBSD/PPC
 #
 (Assignee)

Comment 4

•
10 years ago 
Created attachment 290530 [details] [diff] [review]
ppc.patch

Sigh, there goes. Sorry for the bugspam :)
Attachment #290526 - Attachment is obsolete: true
Attachment #290530 - Flags: review?(timeless)
Attachment #290526 - Flags: review?(timeless)
Assignee: nobody → armin76
Attachment #290530 - Flags: superreview?(benjamin)
Attachment #290530 - Flags: review?(benjamin)

Comment 5

•
10 years ago 
Comment on attachment 290530 [details] [diff] [review]
ppc.patch

ok, fedora, ubuntu (and in a quirky way gentoo) all reached the same conclusion at about the same time.
Attachment #290530 - Flags: review?(timeless)
Attachment #290530 - Flags: review?(benjamin)
Attachment #290530 - Flags: review+

Updated

•
10 years ago
Attachment #290530 - Flags: superreview?(benjamin) → superreview+
Attachment #290530 - Flags: approval1.9?

Updated

•
10 years ago
Attachment #290530 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed

Comment 6

•
10 years ago 
Checking in xpcom/reflect/xptcall/src/md/unix/Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.96; previous revision: 1.95
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
You need to log in before you can comment on or make changes to this bug.