405871 - Ellipsis in software update message is broken on non-Western Windows locales

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P4)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112805 Firefox/3.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112805 Firefox/3.0b2pre

I updated trunk from 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112705 Firefox/3.0b2pre
to
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112805 Firefox/3.0b2pre

When updating , "Software Update" window is displayed. But it's message is broken.

Reproducible: Always

Steps to Reproduce:
1.Update trunk.
2.Check message of "Software Update"
3.
Actual Results:  
Message is broken.

Expected Results:  
It should not be broken.

Comment 1

[Masahiro YAMADA]

Attachment: Screenshot

Comment 2

[Dave Townsend [:mossop]]

Can you confirm this before requesting blocking?

Comment 3

[Phil Ringnalda (:philor)]

I rather doubt it: I suspect it requires a Japanese version of Windows, which would be slow and expensive for me to acquire. So I could meaninglessly confirm it based on the screenshot, or let it slip through the cracks, or nominate it despite our never-questioned, never-explained insistence that unconfirmed bugs cannot be blockers. I chose the third, but either of the other two options available to me would suit me fine, too.

Comment 4

[Masahiro YAMADA]

Attachment: my updater.ini

This bug seems to be caused by broken updater.ini .
Attachment is my updater.ini .
It is valid file?

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

First of all, we don't provide updates for localized nightly builds, so it'd be great if you could explain how you're getting that screenshot. Did you cooked up your own update.xml and mar file ?

Second, the zip and exe on the ftp at  .../firefox/nightly/latest-trunk-1l0n/ have updater.ini which look different to what you have. The top part of updater.ini comes from 
  http://mxr.mozilla.org/l10n/source/ja/browser/updater/updater.ini
which looks like it's localized. The files I unpacked look different to that, even when compared side-by-side in the same browser, so it's possible there is some charset munging going on.

Comment 6

[Masahiro YAMADA]

Strange character after"Firefox is installing your updates and will start in a few moments" seems to be ELLIPSIS encoded by ISO-8859-1.

But , according to comment in updater.ini , it should be encoded by UTF-8.

Comment 7

[Masahiro YAMADA]

(In reply to comment #6)
> Strange character after"Firefox is installing your updates and will start in a
> few moments" seems to be ELLIPSIS encoded by ISO-8859-1.
> 
> But , according to comment in updater.ini , it should be encoded by UTF-8.
> 
Please ignore it.

Cause of broken message is 0x85 0x0A after "moments".
What is the character ?

Binary dump of updater.ini is here.
------------------------
000080   20 66 65 77 20 6D 6F 6D 65 6E 74 73 85 0A 0A 3B  few moments...;

Comment 8

[Masahiro YAMADA]

I'm using Nightly Build downloaded from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/firefox-3.0b2pre.en-US.win32.installer.exe

Comment 9

[Masahiro YAMADA]

I think 85-0A in dump should be E2-80-A6.
And, patch at Bug 373623 seems to be correct.
I think there is some trouble of encoding to apply patch to updater.ini .

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Please ignore comment #5.

Comment 11

[Atsushi Sakai]

(In reply to comment #6)
> But , according to comment in updater.ini , it should be encoded by UTF-8.

This comment is for source file, not for built file.
It is very misleading.

(In reply to comment #7)
> Cause of broken message is 0x85 0x0A after "moments".
> What is the character ?

0x85: "…" in CP1252
0x0A: new line

updater.exe is not Unicode application, so this string must be in CP1252 under English version of Windows.
But Japanese version of Windows requires CP932, so this string is garbled under Japanese Windows.

To fix this, Bug 399153 must be fixed.

Comment 12

[Justin Kerk]

I just got this so confirming. I use an English version of Windows XP, but with the non-Unicode locale set to Japanese in Control Panel->Regional and Language Options->Advanced, so you don't actually have to purchase Japanese windows to reproduce this. It's also the normal English-language nightly.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112905 Minefield/3.0b2pre ID:2007112905

Comment 13

[Mike Connor [:mconnor]]

Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.

Comment 14

[Robert Strong (they/them - no direct email)]

I believe this should be fixed by the landing of bug 399153. This can be tested by performing a software update with tomorrow's build.

Comment 15

[Masahiro YAMADA]

->Fixed.
Tested on update from:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090112 Minefield/3.2a1pre
To:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090113 Minefield/3.2a1pre