Closed Bug 406040 Opened 13 years ago Closed 13 years ago

Add ability to use NPRuntime-based Java Plug-In for only Firefox 3

Categories

(Core :: Plug-ins, enhancement, P2)

x86
Windows XP
enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: kbrussel, Assigned: jst)

References

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112605 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112605 Minefield/3.0b2pre

For several months a new implementation of the Java Plug-In has been under development which uses the NPAPI and NPRuntime plugin and scripting mechanisms rather than the archaic OJI. This work has been done in close cooperation with Mozilla.org and several browser-side changes were needed in order to enable a non-OJI Java Plug-In. This work was done in the Firefox 3 train, so the new plug-in currently works only on Firefox 3.

We have implemented a mechanism to switch between using the old and new Java Plug-Ins in the Java Control Panel. However, the only knobs we have available affect the plug-in used for both Firefox 2 and Firefox 3, because the Firefox browser contains the logic for searching the installed JREs on Windows and finding the Java Plug-In.

The attached patch will allow the old Java Plug-In to be used for existing Firefox 2 installations, and the new Java Plug-In to be optionally used in Firefox 3, depending on the value of the switch set by the Java Control Panel.


Reproducible: Always

Steps to Reproduce:
Not applicable.

Actual Results:  
New Java Plug-In can be used for FF 3 while old can be used for FF 2.


Expected Results:  
Either old or new plug-in is used for both FF 2 and FF 3.
Component: General → Plug-ins
Product: Firefox → Core
QA Contact: general → plugins
Version: unspecified → Trunk
Attachment #290711 - Flags: superreview?(jst)
Attachment #290711 - Flags: review?(rstrong)
Attachment #290711 - Flags: review?(rstrong) → review?(robert.bugzilla)
Assignee: nobody → jst
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.9+
Priority: -- → P2
Comment on attachment 290711 [details] [diff] [review]
Patch to nsPluginDirServiceProvider

>Index: modules/plugin/base/src/nsPluginDirServiceProvider.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/modules/plugin/base/src/nsPluginDirServiceProvider.cpp,v
>retrieving revision 1.20
>diff -c -r1.20 nsPluginDirServiceProvider.cpp
>*** modules/plugin/base/src/nsPluginDirServiceProvider.cpp	7 Nov 2007 09:06:40 -0000	1.20
>--- modules/plugin/base/src/nsPluginDirServiceProvider.cpp	29 Nov 2007 18:39:08 -0000
>***************
>*** 192,197 ****
>--- 192,228 ----
>    return 0;
>  }
>  
>+ // Indicate whether we should use the new NPRuntime-based Java Plug-In
>+ // if it's available
nit: Indicate whether we should try to use
Attachment #290711 - Flags: review?(robert.bugzilla) → review+
Assignee: jst → kenneth.russell
Comment on attachment 290711 [details] [diff] [review]
Patch to nsPluginDirServiceProvider

sr=jst

I'll attach an updated patch for checkin. This is ready to go, and I'll land it as soon as the tree is green again and I have the time to watch this (either later today or over the weekend).
Attachment #290711 - Flags: superreview?(jst) → superreview+
Assignee: kenneth.russell → jst
Status: NEW → ASSIGNED
Attachment #290930 - Flags: superreview+
Attachment #290930 - Flags: review+
Reed or anyone else too, feel free to land this whenever if you beat me to it!
Fix checked in. Thanks for the patch, Kenneth!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Fix has been verified on our side with FF 3 nightly builds dated 12/02 and 12/03. Thanks for the quick integration of the patch.
You need to log in before you can comment on or make changes to this bug.