Closed Bug 406071 Opened 17 years ago Closed 17 years ago

Get rid of the buttondown styling (movement) in classic

Categories

(SeaMonkey :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(2 files, 2 obsolete files)

Our toolbarbuttons shouldn't move upon hover:active. It looks really outdated. To fix this, it looks like could have a bare-bones button.css in classic/communicator/mac and move the .taskbutton styling from tasksoverlay.css to the win/nix version of button.css.
Depends on: 386629
Attached file cvs copies
Since it seems ok to do cvs copying/moves in /suite I'll change the previous attached patch - the style rule changes will be the same, though. Linux will use the win version.
Comment on attachment 290895 [details]
cvs copies

Neil, this is the copying/moving I like to do. I figured, the moving could be done first. Then, I'll move the .taskbutton rules from tasksOverlay.css and remove the hover:active rules in the mac version of button.css.
Attachment #290895 - Flags: superreview?(neil)
Attachment #290895 - Flags: review?(neil)
Attachment #290895 - Flags: superreview?(neil)
Attachment #290895 - Flags: superreview+
Attachment #290895 - Flags: review?(neil)
Attachment #290895 - Flags: review+
Depends on: 406415
We shouldn't actually have any special hover rules either, so I removed them as well - I could then simplify some style rules in mac/button.css (that's the reason for the "moving around style rules" look).
Attachment #290745 - Attachment is obsolete: true
Attachment #290750 - Attachment is obsolete: true
Attachment #291285 - Flags: superreview?(neil)
Attachment #291285 - Flags: review?(mnyromyr)
Comment on attachment 291285 [details] [diff] [review]
Get rid of hover & hover:active rules for mac

>+/* ::::: taskbuttons ::::: */
>+
>+.taskbutton {
>+  padding: 1px;
>+}
>+
>+.taskbutton:hover:active {
>+  padding: 2px 0 0 2px;
>+}
This could really do with a
.toolbarbutton-icon {
  -moz-margin-end: 2px;
}
rule to override winstripe's silly 5px.
Attachment #291285 - Flags: superreview?(neil) → superreview+
(In reply to comment #6)
> (From update of attachment 291285 [details] [diff] [review])
> >+/* ::::: taskbuttons ::::: */
> >+
> >+.taskbutton {
> >+  padding: 1px;
> >+}
> >+
> >+.taskbutton:hover:active {
> >+  padding: 2px 0 0 2px;
> >+}
> This could really do with a
> .toolbarbutton-icon {
>   -moz-margin-end: 2px;
> }
> rule to override winstripe's silly 5px.
> 

Sure, I'll add that to win/button.css.
Attachment #291285 - Flags: review?(mnyromyr) → review+
Checked in attachment #291285 [details] [diff] [review] with those extra lines in win/button.css (comment #6):
+
+.toolbarbutton-icon {
+  -moz-margin-end: 2px;
+}


Checking in suite/themes/classic/jar.mn;
/cvsroot/mozilla/suite/themes/classic/jar.mn,v  <--  jar.mn
new revision: 1.171; previous revision: 1.170
done
Removing suite/themes/classic/communicator/button.css;
/cvsroot/mozilla/suite/themes/classic/communicator/button.css,v  <--  button.css
new revision: delete; previous revision: 1.14
done
Checking in suite/themes/classic/communicator/tasksOverlay.css;
/cvsroot/mozilla/suite/themes/classic/communicator/tasksOverlay.css,v  <--  tasksOverlay.css
new revision: 1.5; previous revision: 1.4
done
Checking in suite/themes/classic/communicator/mac/button.css;
/cvsroot/mozilla/suite/themes/classic/communicator/mac/button.css,v  <--  button.css
new revision: 1.15; previous revision: 1.14
done
Checking in suite/themes/classic/communicator/win/button.css;
/cvsroot/mozilla/suite/themes/classic/communicator/win/button.css,v  <--  button.css
new revision: 1.15; previous revision: 1.14
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
(In reply to comment #8)
> Checked in attachment #291285 [details] [diff] [review] with those extra lines in win/button.css (comment
> #6):
> +
> +.toolbarbutton-icon {
> +  -moz-margin-end: 2px;
> +}
> 

Actually, I was lying:

+
+/* override winstripe */
+
+.toolbarbutton-icon {
+  -moz-margin-end: 2px;
+}
You need to log in before you can comment on or make changes to this bug.