Closed Bug 406111 Opened 13 years ago Closed 12 years ago

Patch to make --disable-svg-foreignobject build smoothly

Categories

(Core :: SVG, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: Techrazy.Yang, Unassigned)

Details

Attachments

(1 file)

Attached patch Patch Splinter Review
When I build Mozilla with --disable-svg-foreignobject, some part of the code which belong to the svg-foreignobject code get compiled and called too. And in this patch, some simple macros added between these code to make a build successfully when user compile with --disable-svg-foreignobject. 

Reproduce:
1. Add --disable-svg-foreignobject to your .mozconfig file and build Mozilla Firefox trunk code. 
2. Get the many undefined reference errors in linkage stage such as "svgForeignObjectFrame" 

Apply this patch will remove these errors.
Hi Bo. You need to CC relevant people and ask for review on patches, otherwise it's possible nobody will see your bug/patch.

Robert, do we want to continue to support --disable-svg-foreignobject?
Hi Jonathan, I have thought the right person would see my reported bug without I CC to him. So, to who should I CC? Is there some place where contain all these information such as who is responsible for which part of code in Mozilla document? 

Thanks!
For SVG that is the case (someone will see your report). In general though, that's not always the case for other parts of the code/bugzilla I think. Either take a look at http://www.mozilla.org/owners.html or else ask in the #developers channel on Mozilla's IRC server.
Rather moot now that bug 450495 has been checked-in. There is not such thing any more as --disable-svg-foreignobject
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.