406113 - Little patch make MinGW gcc not complain

Status: RESOLVED DUPLICATE of bug 405297

(Firefox :: Security, defect)

Description

[Bo Yang]

Attachment: A little patch for MinGW gcc compiling.

When compile Mozilla Firefox trunk source code with MinGW gcc 3.4.5, the compiler complain for the subtraction operation between unsigned char* and char* operand. So, I just convert them to unsigned int before subtraction. 

A little patch but make the MinGW buildable.

Comment 1

[jfwfreo]

This patch is incorrect & will break on 64-bit compiling.
The correct fix is to either typecast the unsigned char * to a char * or the char * to an unsigned char * (which way works better I dont know) which should allow the pointer subtraction to proceed.
BTW, this bug is a duplicate of bug 405297 (which I earlier filed also with the same incorrect patch)

Comment 2

[Bo Yang]

Oh, indeed when I compose this patch I did not consider 64-bit at all, thank you for your correction. And could you please tell me how this patch break the 64-bit?

Thanks!