406134 - change accesskeys for opening and closing tabs and windows

Status: RESOLVED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

Within Firefox (in tab mode) there is Datei->Fenster schliessen which has no underlined character.

browser-menubar.inc:
<menuitem id="menu_closeWindow" hidden="true" command="cmd_closeWindow" key="key_closeWindow" label="&closeWindow.label;"/>

toolkit/chrome/mozapps/help/help.dtd:
<!ENTITY closeWindow.commandkey         "W">

There is no 'W' in 'Fenster schliessen' and therefore the first character seems to be used as commandkey while it's not underlined because of that bug.

That is even worse since Alt-D-F is in many applications associated to open a file.

Reference:
https://bugzilla.novell.com/show_bug.cgi?id=345021

Comment 1

[Martin Creutziger [:MMx]]

Please don't mix Command Keys and Access Keys, the command key should stay "W", like Cmd+W on Mac (Strg+W on PC)

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Oops, sorry, you are right.
So the issue is probably that there is no accesskey defined and therefore a default is used?

Comment 3

[Kadir Topal [:atopal]]

There is an accesskey defined, it's f and it does show up on Windows, I didn't test in on Linux.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

OK, let me specify a bit more:
I'm talking about Mozilla 1.8 branch (aka Firefox 2.x) and there is no accesskey defined as seen in the menuitem element above.
I missed to provide that information as it's mentioned in the Novell bug.
Checking 1.9 (FF 3.0) there is one defined indeed.

Comment 5

[Christian Boltz]

(In reply to comment #3)
> There is an accesskey defined, it's f and it does show up on Windows, I
> didn't test in on Linux.

Please change the accesskey to something else than F, see the initial comment:
> That is even worse since Alt-D-F is in many applications associated to open
> a file.

Explicitely setting F as accesskey doesn't make it better ;-)

Comment 6

[Axel Hecht [:Pike]]

So, this bug is WONTFIX on the 1.8 branch, that'd be an l10n-impact change on all localizations, which we're not going to take.

I guess that folks here would like to see the accesskey of Datei öffnen to change, too?

<!ENTITY openFileCmd.accesskey "ö">?

I'm leaving that up to Abdulkadir.

Comment 7

[Kadir Topal [:atopal]]

Well, we should try not to use umlauts, but yes, taking. 

Comment 8

[Kadir Topal [:atopal]]

Okay. a few changes here: 
"Datei öffnen" uses "f"
"Fenster schließen" uses "r"
and I also changed "Tab schließen" to "c", before, it was "s" and IE uses that for "Save", so pretty much the opposite.