406223 - A SetCanonicalPixelScale()-based zoom implementation for the QNX Firefox 2.0 based browser.

Status: RESOLVED WONTFIX

(Firefox :: Shell Integration, defect)

Description

[Max Feil - mfeil%qnx.com]

A SetCanonicalPixelScale()-based zoom implementation for the QNX Firefox 2.0 based browser.

The changes are all in QNX-only code under gfx/src/photon and widget/src/photon. These are not part of Tinderbox builds so they cannot cause any bustage. There are also some additional changes to try and improve the quality of resized images and fonts.

For more details see the attached patches.

Comment 1

[Max Feil - mfeil%qnx.com]

Attachment: MOZILLA_1_8_BRANCH changes under gfx/src/photon

These changes do not apply to TRUNK because a different Cairo based graphical rendering will be used there.

Comment 2

[Max Feil - mfeil%qnx.com]

Attachment: MOZILLA_1_8_BRANCH changes under widget/src/photon

Comment 3

[Benjamin Smedberg]

Comment on attachment 290916 [details] [diff] [review]
MOZILLA_1_8_BRANCH changes under widget/src/photon

I'm not a module owner of this code... asking the correct module owner for MOA for photon-specific changes.

Comment 4

[Benjamin Smedberg]

Comment on attachment 290914 [details] [diff] [review]
MOZILLA_1_8_BRANCH changes under gfx/src/photon

Asking module owner for moa for photon-specific changes.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think we should just rubber-stamp any and all Photon-only changes. Stuart, Benjamin, are you in favour?

Comment 6

[Benjamin Smedberg]

Just for history, there was a photon-specific change that occurred in xptcall which was not obviously photon-specific, so I asked that I be given review requests in that case. I think that rubber-stamping in general for photon-specific directories (gfx/src/photon or widget/src/photon) is the correct thing to do.

Comment 7

[Stuart Parmenter]

Comment on attachment 290914 [details] [diff] [review]
MOZILLA_1_8_BRANCH changes under gfx/src/photon

rs=me

Comment 8

[Matthias Versen [:Matti]]

Photon support got removed with bug 563462