406307 - bug origresize+bug locationbarno + winhidechrome

Status: RESOLVED WONTFIX

(Mozilla Labs :: Prism, defect)

Description

[Jerome Etienne]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.6) Gecko/20061201 Firefox/2.0.0.6 (Ubuntu-feisty)
Build Identifier: prism0.8

sorry i failed to understand how to produce individual patches after trying for 2h. and i dont have more time for now. so here is a bundle of the modification i made:

1. bug origresize
- when the window is first open, it takes the dimension of the <window> tag
- this cause the window manager to possibily reposition the window on the 
  screen. eg if the width/height do not fit in the screen
- having those hardcoded width/heigh in <window> cause it to be impossible
  to save a location on bottom left

2. bug locationbarno
- when .webapps, contain locationbar=no, 2 grays line remains on top of the 
  window. most likely the border of a widget
- fixed by hidding the whole toolbox

3. feature hidechrome
- i added "window_hidechrome" variable in .webapps
- it default to false
- if true, it hide the chrome on the <window>

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Jerome Etienne]

Attachment: patch for the 3 stuff described here

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

#1 has been fixed in bug 425128
#3 is close to landing, but we need a way to allow the window to be dragged and allow the command menu to be displayed

Comment 3

[Matthew Gertner]

Is there a bug filed for #3? I don't know anything about this. What is the status?

Comment 4

[Stephanie Daugherty [:sdaugherty]]

If this is still an issue, it needs to be broken up and the patch updated - one change (and ideally one patch) per bug, and the patches updated. Also see comment 2 - most likely only the second item needs to be fixed.

As far as separating out patches, a best practice is to develop on feature branches within your own personal hg repository with one branch per bug - this way you can easily keep your patches up to date until they are applied. See http://mercurial.selenic.com/wiki/NamedBranches (A lot of people will simply name these branches by bug number ie bug-12345)

Comment 5

[chawlaashish5]

done

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Prism isn't maintained anymore. Mass closing of the bugs.