406475 - Menus displaying wrong arrows

Status: RESOLVED INCOMPLETE

(Core :: Widget: Gtk, defect)

Description

[Michael Monreal [:micmon]]

After bug 404493, menus display a native looking GTK arrow for submenus. But this is in fact the arrow that is used in the scrollbars. It is slightly different from the correct arrow in Clearlooks. Other themes like ThinIce are more obvious. The scrollbar arrow is tiny in this theme, the submenu arrow normal size. Firefox displays tiny menu arrows.

Comment 1

[Michael Monreal [:micmon]]

Attachment: Clearlooks arrows: GTK and firefox

Comment 2

[Michael Ventnor]

It is the arrow used in submenus. What you're seeing is just a different size. In CSS the arrow is set to 1ex so the arrow will change size along with the text, like native arrows do.

Maybe you could change this value and find the perfect one?

Comment 3

[Michael Monreal [:micmon]]

Are you really sure this is the same arrow? On gtk apps, the tip of the arrow is 2 lines of pixels at my size. I cannot get the same look using a different scaling factor in FF.

Anyway, setting width and height to 1.2ex is probably good enough.

Comment 4

[Till Berger]

They do at least have the wrong size in some themes. I’ll attach a screenshot of this bug with the Glider theme.

Comment 5

[Till Berger]

Attachment: Comparison Epiphany—Firefox

On the left side Epiphany’s view menu, on the right the one of Firefox. In Firefox the arrow is too small.

Comment 6

[Michael Monreal [:micmon]]

The scaling factor seems to affect different themes differently...

Comment 7

[Michael Monreal [:micmon]]

Will this be fixed when bug 416003 is resolved?

Comment 8

[Teune van Steeg]

(In reply to comment #7)
> Will this be fixed when bug 416003 is resolved?
> 
No, this will require its own fix. Currently, even with the patch for bug 416003, we can only draw arrows inside a button pointing down, we still need the code to draw native arrows inside a button pointing to the left or to the right.

Comment 9

[Teune van Steeg]

(In reply to comment #8)
> (In reply to comment #7)
> > Will this be fixed when bug 416003 is resolved?
> > 
> No, this will require its own fix. Currently, even with the patch for bug
> 416003, we can only draw arrows inside a button pointing down, we still need
> the code to draw native arrows inside a button pointing to the left or to the
> right.
> 

I'm sorry, forget the previous comment, it doesn't make any sense regarding this bug: I actually thought that I was replying to a comment in bug 412773.

Comment 10

[Michael Monreal [:micmon]]

No longer relevant with Photon theme.