Created attachment 291124 [details] [diff] [review] fix
Attachment #291124 - Flags: review?(sspitzer)
Comment on attachment 291124 [details] [diff] [review] fix r=sspitzer I think in nsPlacesTransactionsService.js we use both this.id and this._id. I really wish we just did one, and I think this._id is the more common one. We had bugs caused by mixing them up, and I think we even have a code clean bug about not doing this.id. Can you use this._id instead?
Attachment #291124 - Flags: review?(sspitzer) → review+
the id is modified externally for nested transactions, so we should probably standardize on .id instead of ._id.
> We had bugs caused by mixing them up, and I think we even have a code clean bug > about not doing this.id. > bug 390007
Comment on attachment 291124 [details] [diff] [review] fix drivers: blocking a blocker.
Attachment #291124 - Flags: approval1.9?
Comment on attachment 291124 [details] [diff] [review] fix a=beltzner for 1.9
Attachment #291124 - Flags: approval1.9? → approval1.9+
Checking in browser/components/places/content/utils.js; /cvsroot/mozilla/browser/components/places/content/utils.js,v <-- utils.js new revision: 1.92; previous revision: 1.91 done Checking in browser/components/places/public/nsIPlacesTransactionsService.idl; /cvsroot/mozilla/browser/components/places/public/nsIPlacesTransactionsService.idl,v <-- nsIPlacesTransactionsService.idl new revision: 1.9; previous revision: 1.8 done Checking in browser/components/places/src/nsPlacesTransactionsService.js; /cvsroot/mozilla/browser/components/places/src/nsPlacesTransactionsService.js,v <-- nsPlacesTransactionsService.js new revision: 1.11; previous revision: 1.10 done Checking in browser/components/places/tests/unit/test_placesTxn.js; /cvsroot/mozilla/browser/components/places/tests/unit/test_placesTxn.js,v <-- test_placesTxn.js new revision: 1.13; previous revision: 1.12 done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.