406528 - if a page has no title (including a redirect) we need to clear the previous title

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

if a page has no title or is a redirect, we need to clear the previous title

this bug comes in a few flavors:

a)

1) page doesn't exist, so you get a 404 title (like "www.sspitzer.org Error page" for http://www.sspitzer.org/foobarcheese.html)
2) then, I create that page, but I don't give it a title

in moz_places, we continue to use "www.sspitzer.org Error page".  that will show up in in url bar autocomplete, places organizer, history sidebar, etc.

b) a site that normally redirects, like mail.polvi.net is temporarily down, so you get a 5xx message.  when it comes back, the title remains bogus (see screen shot.)

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: polvi's screen shot

Comment 2

[(not reading, please use [e-mail] instead)]

hmm, I'm not 100% certain that what polvi is seeing (case b) is the same as what I can reproduce (case a), but both are bugs.

Comment 3

[Alex Polvi]

Also, if you 401 on a file... then get it later... the title will still be a 401 if the page has no title. 

Comment 4

[Alex Polvi]

If the title of a page changes we should always update it -- even if it means updating to a blank title. 

Consider this example, gmail.com redirects to mail.google.com. If just one time gmail.com is a 404 when the user hits it, it will always be "404 not found" because the properly working redirect has a blank title. This is inconsistent and misleading.

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch

made so if the title is empty we nullify it, and fixed some wrong check i've found in nsNavHistory title related functions

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 303506 [details] [diff] [review]
patch

r=me, thanks for the fix and the cleanup.

Comment 7

[Reed Loden [:reed]]

Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.251; previous revision: 1.250
done

Comment 8

[Tracy Walker [:tracy]]

Verified with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042906
Minefield/3.0pre

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv