Closed Bug 406634 Opened 17 years ago Closed 7 years ago

switch url-classifier unit tests to use hash-encoded data

Categories

(Toolkit :: Safe Browsing, defect, P3)

Product:
Toolkit
Component:
Safe Browsing
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 750751

People

(Reporter: dcamp, Unassigned)

Details

Right now the url-classifier unit tests use plaintext urls when populating the database, which uses a different codepath in nsUrlClassifierDBServiceWorker::GetChunkEntries().

We should change the unit tests to feed data in the hashed format used by the protocol.
I couldn't agree more: the fact that all tests are using a different codepath from the production code is one of the most annoying issues with the current (and new!) SB code, an additional complication, a cause of bugs, and a cause of codebloat.
Product: Firefox → Toolkit
Priority: -- → P2
Whiteboard: tpe-seceng
Assignee: nobody → tnguyen
Assignee: tnguyen → nobody
Priority: P2 → P3
Whiteboard: tpe-seceng
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.