406666 - Identity popup needs aligning

Status: RESOLVED FIXED

(Firefox :: General, defect, P4)

Description

[Michael Monreal [:micmon]]

The text in the identity popup needs to be aligned somehow... right now it looks very weird, as if it just displays random information.

Comment 1

[Michael Monreal [:micmon]]

Attachment: Marked Screenshot

I hope this shows what I mean...

Comment 2

[Florian Quèze [:florian]]

Also, "Tell me more about this web site..." should never be cropped (visible on your second screenshot).

Comment 3

[Johnathan Nightingale [:johnath]]

Attachment: Fix padding, whitespace on labels, drop encryption text back when padlock shown

I think this should fix it - can I get linux and windows confirmation before I ask for review/approval?

Comment 4

[Carsten Book [:Tomcat]]

Attachment: screenshot from a tryserver build with this patch applied

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre)
Gecko/2007121012 Minefield/3.0b2pre - looks good on fedora f8

Comment 5

[Johnathan Nightingale [:johnath]]

Attachment: Larry on Mac with patch

Mac seems to align perfectly with this patch, but linux seems to still inset the title and link less than the other text.  Those two are <label> tags, whereas the rest are <descriptions>, which is likely the source of the discrepancy - do labels have different global styling in gnomestripe?

Comment 6

[Johnathan Nightingale [:johnath]]

Attachment: Zero margin-left on windows/linux

Windows and Linux were both showing indentation which it turns out is caused by:

http://mxr.mozilla.org/mozilla/source/toolkit/themes/winstripe/global/formatting.css#146

Toolkit gives descriptions a 5px margin in winstripe, but not in pinstripe.  This version zeroes it out for the identity popup.

Comment 7

[Carsten Book [:Tomcat]]

Attachment: new screenshot

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre)
Gecko/2007121016 Minefield/3.0b2pre - tryserver build

Comment 8

[Johnathan Nightingale [:johnath]]

Comment on attachment 292490 [details] [diff] [review]
Zero margin-left on windows/linux

Nom'ng for approval.  This is a polish bug, low risk, CSS only.

Comment 9

[Johnathan Nightingale [:johnath]]

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.146; previous revision: 1.145
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.102; previous revision: 1.101
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.142; previous revision: 1.141
done