Please add 'back' and 'forward' stock icons to help viewer under Linux.

RESOLVED FIXED in Firefox 3 beta3

Status

()

Firefox
Shell Integration
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Hussam Al-Tayeb, Assigned: sikon)

Tracking

Trunk
Firefox 3 beta3
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007120401 Firefox/3.0b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007120401 Firefox/3.0b2pre

Stock back/forward/home/print icons are already used in firefox toolbar and bookmark organizer under Linux. Please add those to help viewer as well.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Reporter)

Updated

11 years ago
Version: unspecified → Trunk
(Reporter)

Updated

11 years ago
Component: General → OS Integration
QA Contact: general → os.integration

Updated

11 years ago
Blocks: 381206
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 1

11 years ago
Created attachment 292563 [details] [diff] [review]
Patch

Attaching a patch. The help.css file is taken from winstripe and modified.
Attachment #292563 - Flags: review?(mconnor)
Assignee: nobody → sikon
Comment on attachment 292563 [details] [diff] [review]
Patch

Ryan can review this quicker than mconnor can, most likely. :)
Attachment #292563 - Flags: review?(mconnor) → review?(rflint)
Comment on attachment 292563 [details] [diff] [review]
Patch

This needs a Makefile in help/ (a copy from http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/help/Makefile.in should do nicely).

>diff -U 8 -urpN toolkit/themes/gnomestripe/help/help.css toolkit/themes/gnomestripe/help/help.css
>+#search-sidebar-closebutton {
>+  border: 1px solid transparent;
>+  padding: 3px 2px 4px 2px !important;
>+  list-style-image: url("moz-icon://stock/gtk-close?size=menu");
>+  -moz-appearance: none;
>+}
Ditch the border, padding and -moz-appearance here.

Looks good otherwise - if you feel like getting rid of the old, silly, all-caps comments, that would be great too :)
Attachment #292563 - Flags: review?(rflint) → review-
(Assignee)

Comment 4

11 years ago
Created attachment 292587 [details] [diff] [review]
Patch v2

New try.
Attachment #292563 - Attachment is obsolete: true
Attachment #292587 - Flags: review?(rflint)
(Reporter)

Comment 5

11 years ago
Your patch doesn't use 'disabled' back and forward images.
(Assignee)

Updated

11 years ago
Attachment #292587 - Flags: review?(rflint)
(Assignee)

Comment 6

11 years ago
Created attachment 292604 [details] [diff] [review]
Patch including state=disabled
Attachment #292587 - Attachment is obsolete: true
Attachment #292604 - Flags: review?(rflint)
Attachment #292604 - Flags: review?(rflint) → review+
Attachment #292604 - Flags: approval1.9?

Updated

11 years ago
Attachment #292604 - Flags: approval1.9? → approval1.9+

Updated

11 years ago
Keywords: checkin-needed
Thanks for the patch!

Checking in toolkit/themes/gnomestripe/Makefile.in;
/cvsroot/mozilla/toolkit/themes/gnomestripe/Makefile.in,v  <--  Makefile.in
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/help/Makefile.in,v
done
Checking in toolkit/themes/gnomestripe/help/Makefile.in;
/cvsroot/mozilla/toolkit/themes/gnomestripe/help/Makefile.in,v  <--  Makefile.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/help/help.css,v
done
Checking in toolkit/themes/gnomestripe/help/help.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/help/help.css,v  <--  help.css
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/help/jar.mn,v
done
Checking in toolkit/themes/gnomestripe/help/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/help/jar.mn,v  <--  jar.mn
initial revision: 1.1
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
You need to log in before you can comment on or make changes to this bug.