Fix look of extension warning

RESOLVED FIXED in mozilla1.9beta3

Status

()

RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: micmon, Assigned: ventnor.bugzilla)

Tracking

Trunk
mozilla1.9beta3
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

11 years ago
Today's update told me that some extensions will stop working. The notification looked a bit broken because there was no line at the top and left. A simple fix, also changing the color:

#incompatibleWarning {
  border: 1px solid ThreeDShadow !important;
}
(Reporter)

Comment 1

11 years ago
Created attachment 291420 [details]
Before/After screenshot
(Assignee)

Comment 2

11 years ago
Created attachment 297492 [details] [diff] [review]
Patch

This should fix it. We'll also use stock icons in the process.
Assignee: nobody → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #297492 - Flags: review?(rflint)
(Reporter)

Comment 3

11 years ago
+.licenseLoadingThrobber[state="error"] {
+  list-style-image: url("moz-icon://stock/gtk-stop?size=menu");

and

+#verificationFailedIcon {
+  list-style-image: url("moz-icon://stock/gtk-stop?size=menu");

should not be used IMHO. There is no way of telling that "gtk-stop" looks anywhere near "error" or "failed". The same mistake was checked in for the find bar and the error console menu icon. We will need to replace those with proper error icons as soon as they are ready (M3). It's a bit sad that we have to ship a full tango set of Error/Warning/etc icons, as GTK only provides once size (32x32) and we need them all (16, 24, 32, 48).

Perhaps even check the gtk-stop in for now and we grep the whole theme when the dialog icons are in to find out were we need to use an error icon?
Comment on attachment 297492 [details] [diff] [review]
Patch

Might want to just leave the current icons as-is until they're tangoized as it'll make 'em easier to find later. r=me otherwise.
Attachment #297492 - Flags: review?(rflint) → review+
Comment on attachment 297492 [details] [diff] [review]
Patch

woo woo look-n-feel
Attachment #297492 - Flags: approval1.9?

Comment 6

11 years ago
Comment on attachment 297492 [details] [diff] [review]
Patch

Yea - this is great!
Attachment #297492 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 7

11 years ago
Created attachment 298755 [details] [diff] [review]
Patch 2

IMO its best to use stock icons at every opportunity so that we can feel native anywhere, including high-contrast themes or KDE.
Attachment #297492 - Attachment is obsolete: true
(Assignee)

Updated

11 years ago
Keywords: checkin-needed
(Reporter)

Comment 8

11 years ago
(In reply to comment #7)
> IMO its best to use stock icons at every opportunity so that we can feel native
> anywhere, including high-contrast themes or KDE.

Right... that would be easy to achieve if firefox would depend on a freedesktop compliant icon theme. With just GTK stock, we are sadly quite limited. Perhaps worth reconsidering for firefox 3.5?
Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.6; previous revision: 1.5
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/update/updates.css,v
done
Checking in toolkit/themes/gnomestripe/mozapps/update/updates.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/update/updates.css,v  <--  updates.css
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.