406765 - GCC warns about uninitialized variable in js_EmitTree

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Igor Bukanov]

After landing the patch for bug 376957 GCC has started to complain at -Os optimization:

gcc -o Linux_All_DBG.OBJ/jsemit.o -c -Wall -Wno-format -DGCC_OPT_BUG -g -DXP_UNIX -DSVR4 -DSYSV -D_BSD_SOURCE -DPOSIX_SOURCE -DHAVE_LOCALTIME_R -DX86_LINUX  -DDEBUG -DDEBUG_igor -DJS_THREADSAFE -DEDITLINE -ILinux_All_DBG.OBJ -I/home/igor/build/browser-trunk-dbg/dist/include/nspr -Os jsemit.c
jsemit.c: In function 'js_EmitTree':
jsemit.c:3916: warning: 'ale' may be used uninitialized in this function

It would be nice to address this annoyance.

Comment 1

[Igor Bukanov]

Attachment: fix v1

The patch adds ale = NULL to quell GCC and changes the switch into the if/else with asserts to minimize the code.

Comment 2

[Igor Bukanov]

The bug blocks 376957 as this is formally a regression.

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 291422 [details] [diff] [review]
fix v1

Whoops, thanks for fixing. Waldo can r+ too (I think he's a peer -- he should be if not, I think).

/be

Comment 4

[Jeff Walden [:Waldo]]

Yeah, I am -- looks good to me.

Comment 5

[Igor Bukanov]

Comment on attachment 291422 [details] [diff] [review]
fix v1

This is a fix for GCC warning to have less noise when compiling SpiderMonkey.

Comment 6

[Damon Sicore (:damons)]

Comment on attachment 291422 [details] [diff] [review]
fix v1

Taking this as it is a P2.

Comment 7

[Igor Bukanov]

I checked in the patch from comment 1 to the CVS trunk:

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1196931120&maxdate=1196931192&who=igor%mir2.org