Add support for an option to show/hide hidden microformats

RESOLVED FIXED

Status

()

Toolkit
Microformats
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Created attachment 291442 [details] [diff] [review]
Fix for problem

I'm adding a new option so that the developer can decide if they want to show or hide hidden microformats (display:none)

This requires changing recurseFrames to an options JS structure (which I should have done in the first place)
Attachment #291442 - Flags: review?(sayrer)
(Assignee)

Updated

10 years ago
Attachment #291442 - Flags: review?(sayrer) → review?(benjamin)

Comment 1

10 years ago
Comment on attachment 291442 [details] [diff] [review]
Fix for problem

This tentatively looks ok, but it's not approved to land without a unit-test.
Attachment #291442 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

10 years ago
Created attachment 292678 [details] [diff] [review]
Unit test for new functionality

Unit test and fixes to previous tests because of this functionality.
(Assignee)

Comment 3

10 years ago
Comment on attachment 291442 [details] [diff] [review]
Fix for problem

This is a small update to the microformats API with unit test
Attachment #291442 - Flags: approval1.9?

Updated

10 years ago
Attachment #291442 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 4

10 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.