406828 - Pinstripe shouldn't use unified

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Colin Barrett [:cbarrett]]

Attachment: fix v1.0

This is basically a back out of bug 402125. Things have changed since that bug was landed (We now blend in on the OS we're running on, for one), and we're getting complaints that the current state of things is confusing on Leopard -- right now there's not a lot of indication if Firefox is in the foreground or not.

This isn't a "permanent" change, in that ideally we should be landing the new mac theme Proto before we ship -- it's just to make life easier for beta testers and to address a common complaint.

We want this for beta2, as per discussion on email.

Comment 1

[Colin Barrett [:cbarrett]]

by "ship" i meant ship Firefox 3 final, not beta 2.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 291477 [details] [diff] [review]
fix v1.0

I would like to keep globalBindings.xml in place so themes can copy it over and apply it on a per-window basis.

Comment 3

[Colin Barrett [:cbarrett]]

Attachment: fix v1.1

I *think* this what he wanted, I'm no XUL wizard though :)

Might be too late for Mano, he's not on IRC.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 291519 [details] [diff] [review]
fix v1.1

r=mano-still-awake.

Comment 5

[Colin Barrett [:cbarrett]]

Comment on attachment 291519 [details] [diff] [review]
fix v1.1

apparently sr is unneeded

Comment 6

[Colin Barrett [:cbarrett]]

Comment on attachment 291519 [details] [diff] [review]
fix v1.1

Either approval1.9 or marking this bug as blocking will work.

Comment 7

[Colin Barrett [:cbarrett]]

Testcase for QA for this is that there is now a line between the titlebar and the toolbar. Basically a back out of bug 402125.

Checking in toolkit/themes/pinstripe/global/global.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/global.css,v  <--  global.css
new revision: 1.17; previous revision: 1.16
done
Checking in toolkit/themes/pinstripe/global/toolbar.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/toolbar.css,v  <--  toolbar.css
new revision: 1.13; previous revision: 1.12
done

Comment 8

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; es-ES; rv:1.9b2pre) Gecko/2007120504 Minefield/3.0b2pre

For both Tiger and Leopard builds.