406944 - cmd/ctrl+enter does not work on Mac

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[:Gijs (he/him)]

STR:
1. type "/echo foo" in the single line input box
2. hit ctrl+enter

AR:
Nothing happens


2b. hit cmd+enter

AR:
"/echo foo" gets executed


ER: either or both of these should do "/say /echo foo" instead.

Comment 1

[:Gijs (he/him)]

So here's something interesting: if you use ctrl+enter on mac, the keycode is actually 77. Go figure. Actually, I tried to do precisely that and can't figure out why this is the case, but anyway, that's what's screwing us here. We could wallpaper over it, of course, but I'd really like to know why the hell it uses a different keycode...

Comment 2

[:Gijs (he/him)]

So, of course, it works on trunk. I blame carbon. Do we want a wallpaper for branch only? I suppose that'd help at least the Fx 2.0 users and such...

Comment 3

[:Gijs (he/him)]

Attachment: Patch

Wallpaper. This is not very neat, but I preferred copying the default code over copying the Return code. Not sure which would be better...

Comment 4

[James Ross]

Comment on attachment 295758 [details] [diff] [review]
Patch

This is a bug in the 1.8 branch DOM code - include a bug# in the comment if there is one. You should also note in the comment that 77 = "M", and Control-M is the old-school way to enter the CR code.

r=silver

Comment 5

[:Gijs (he/him)]

Attachment: Better Patch

Didn't test this one, but I'm pretty sure it should function the same, and code-wise it's a lot neater.

Comment 6

[James Ross]

Comment on attachment 295826 [details] [diff] [review]
Better Patch

Please include the note about 77 == "M", and that Control-M is old-school <Enter>.

Comment 7

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/handlers.js;
/cvsroot/mozilla/extensions/irc/xul/content/handlers.js,v  <--  handlers.js
new revision: 1.165; previous revision: 1.164
done