406982 - Toolbar separator margin too big

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Michael Monreal [:micmon]]

The margin from a toolbar separator to the previous/next item is about two pixels too big.

Comment 1

[Michael Monreal [:micmon]]

Attachment: FF (above) and GTK (below)

Comment 2

[Ian Spence]

Working on a fix, I believe it's caused by the margin declaration being in em, which really messes up my width logic, since the width isn't supposed to be based on font size

Comment 3

[Ian Spence]

Attachment: Removes the hackish nature of the separator box model

This removes the hackish way the separator used to be made so that the new native version works correctly.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 291956 [details] [diff] [review]
Removes the hackish nature of the separator box model

a=mconnor on behalf of drivers for 1.9 checkin.

Comment 5

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/global/toolbar.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/toolbar.css,v  <--  toolbar.css
new revision: 1.12; previous revision: 1.11
done