Looking for saved searches? click on "Search Bugs" above.

Toolbar separator margin too big

RESOLVED FIXED in Firefox 3 beta3

Status

()

Product:
Firefox
Component:
Shell Integration
RESOLVED FIXED
Reported:
10 years ago
Modified:
10 years ago

People

(Reporter: micmon, Assigned: Ian Spence)

Tracking

Version:
Trunk
Target:
Firefox 3 beta3
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

FF (above) and GTK (below)
4.46 KB, image/png
Details
Removes the hackish nature of the separator box model
890 bytes, patch
roc
: review+
roc
: superreview+
mconnor
: approval1.9+
Details | Diff | Splinter Review
(Reporter)

Description

•
10 years ago 
The margin from a toolbar separator to the previous/next item is about two pixels too big.
(Reporter)

Comment 1

•
10 years ago 
Created attachment 291670 [details]
FF (above) and GTK (below)
 (Assignee)

Comment 2

•
10 years ago 
Working on a fix, I believe it's caused by the margin declaration being in em, which really messes up my width logic, since the width isn't supposed to be based on font size
Status: NEW → ASSIGNED
 (Assignee)

Comment 3

•
10 years ago 
Created attachment 291956 [details] [diff] [review]
Removes the hackish nature of the separator box model

This removes the hackish way the separator used to be made so that the new native version works correctly.
Assignee: nobody → ispence
Attachment #291956 - Flags: superreview?(roc)
Attachment #291956 - Flags: review?(roc)
Summary: Toolbar separator magin too big → Toolbar separator margin too big
Component: Widget: Gtk → OS Integration
Product: Core → Firefox
QA Contact: gtk → os.integration
Attachment #291956 - Flags: superreview?(roc)
Attachment #291956 - Flags: superreview+
Attachment #291956 - Flags: review?(roc)
Attachment #291956 - Flags: review+
 (Assignee)

Updated

•
10 years ago
Attachment #291956 - Flags: approval1.9?

Comment 4

•
10 years ago 
Comment on attachment 291956 [details] [diff] [review]
Removes the hackish nature of the separator box model

a=mconnor on behalf of drivers for 1.9 checkin.
Attachment #291956 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed

Comment 5

•
10 years ago 
Checking in toolkit/themes/gnomestripe/global/toolbar.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/toolbar.css,v  <--  toolbar.css
new revision: 1.12; previous revision: 1.11
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
You need to log in before you can comment on or make changes to this bug.