Looking for saved searches? click on "Search Bugs" above.

Download manager should use more Linux stock icons

VERIFIED FIXED in mozilla1.9beta3

Status

()

Toolkit
Downloads API
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Michael Ventnor, Assigned: Michael Ventnor)

Tracking

Trunk
mozilla1.9beta3
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Created attachment 291741 [details]
downloads.css file

Yet another innocent victim of the radical shift to nativeness on Linux: the download manager. The icons already there just don't seem right.

Since this requires the creation of a new directory, and since I lack CVS write access, I can't attach a patch. Needless to say that is pretty pointless since I'm creating a new file anyway so I'm attaching the whole file here.

Reed: when you checkin please create toolkit/themes/gnomestripe/mozapps/downloads/ and put this file in it as downloads.css. I'll attach a jar.mn patch soon.
Attachment #291741 - Flags: review?(gavin.sharp)
(Assignee)

Comment 1

10 years ago
Created attachment 291743 [details] [diff] [review]
Subsequent jar.mn patch
Attachment #291741 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

10 years ago
Attachment #291741 - Flags: approval1.9?

Updated

10 years ago
Attachment #291741 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloads.css,v
done
Checking in toolkit/themes/gnomestripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloads.css,v  <--  downloads.css
initial revision: 1.1
done

I really screwed up the commit log message for this commit, so I filed bug 407871 to fix it.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11

Comment 3

10 years ago
The jar.mn needs a "+" in front of the download.css line. Otherwise, the downloads.css from winstripe could take precedence.
(In reply to comment #3)
> The jar.mn needs a "+" in front of the download.css line. Otherwise, the
> downloads.css from winstripe could take precedence.

Thanks, fixed.

Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.3; previous revision: 1.2
done
Verified; I used Fedora Core 8 (stock).  Looks great!

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008020204 Minefield/3.0b3pre
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.