407044 - Download manager should use more Linux stock icons

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Michael Ventnor]

Attachment: downloads.css file

Yet another innocent victim of the radical shift to nativeness on Linux: the download manager. The icons already there just don't seem right.

Since this requires the creation of a new directory, and since I lack CVS write access, I can't attach a patch. Needless to say that is pretty pointless since I'm creating a new file anyway so I'm attaching the whole file here.

Reed: when you checkin please create toolkit/themes/gnomestripe/mozapps/downloads/ and put this file in it as downloads.css. I'll attach a jar.mn patch soon.

Comment 1

[Michael Ventnor]

Attachment: Subsequent jar.mn patch

Comment 2

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloads.css,v
done
Checking in toolkit/themes/gnomestripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloads.css,v  <--  downloads.css
initial revision: 1.1
done

I really screwed up the commit log message for this commit, so I filed bug 407871 to fix it.

Comment 3

[Sylvain Pasche]

The jar.mn needs a "+" in front of the download.css line. Otherwise, the downloads.css from winstripe could take precedence.

Comment 4

[Reed Loden [:reed]]

(In reply to comment #3)
> The jar.mn needs a "+" in front of the download.css line. Otherwise, the
> downloads.css from winstripe could take precedence.

Thanks, fixed.

Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.3; previous revision: 1.2
done

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified; I used Fedora Core 8 (stock).  Looks great!

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008020204 Minefield/3.0b3pre