Closed
Bug 407053
Opened 17 years ago
Closed 17 years ago
"Assertion failure: (cx)->requestDepth || (cx)->thread == (cx)->runtime->gcThread" with document.execCommand('copy', ...)
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: jruderman, Assigned: peterv)
References
Details
(Keywords: assertion, testcase)
Attachments
(3 files)
131 bytes,
text/html
|
Details | |
698 bytes,
patch
|
jst
:
review+
jst
:
superreview+
sicking
:
approval1.9+
|
Details | Diff | Splinter Review |
342 bytes,
text/html
|
Details |
Loading the testcase triggers:
Assertion failure: (cx)->requestDepth || (cx)->thread == (cx)->runtime->gcThread, at /Users/jruderman/trunk/mozilla/js/src/jsapi.c:5061
Stack trace:
JS_Assert
JS_InternString
nsHTMLDocument::DoClipboardSecurityCheck
nsHTMLDocument::ExecCommand
NS_InvokeByIndex_P
...
Flags: blocking1.9?
Reporter | ||
Updated•17 years ago
|
Attachment #291755 -
Attachment mime type: application/xhtml+xml → text/html
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #291765 -
Flags: superreview?(jst)
Attachment #291765 -
Flags: review?(jst)
Comment 2•17 years ago
|
||
Comment on attachment 291765 [details] [diff] [review]
v1
JSContext *cx = nsnull;
stack->Peek(&cx);
+ JSAutoRequest ar(cx);
We should have code here that makes sure cx is non-null, and probably return an error if it's null (to be on the safe side).
r+sr=jst with that.
Attachment #291765 -
Flags: superreview?(jst)
Attachment #291765 -
Flags: superreview+
Attachment #291765 -
Flags: review?(jst)
Attachment #291765 -
Flags: review+
Attachment #291765 -
Flags: approval1.9+
Comment 4•17 years ago
|
||
i can trigger this assertion/abort in another function with another testcase.
Assertion failure: (cx)->requestDepth || (cx)->thread == (cx)->runtime->gcThread, at firefox-cvs/mozilla/js/src/jsapi.c:4063
firefox-cvs/mozilla/fb-opt-static/dist/bin/run-mozilla.sh: line 131: 3051 Trace/breakpoint trap "$prog" ${1+"$@"}
is this different bug?
Comment 5•17 years ago
|
||
same assertion in JS_GetReservedSlot is Bug 410486
Assignee | ||
Comment 6•17 years ago
|
||
(In reply to comment #2)
> We should have code here that makes sure cx is non-null, and probably return an
> error if it's null (to be on the safe side).
Actually, I don't see why calling ExecCommand for the clipboard commands without JS on the stack should throw an error, so I'm making it return NS_OK if cx is null. Let me know if you disagree with that.
Assignee | ||
Comment 7•17 years ago
|
||
Checked in (with crashtest).
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
OS: Mac OS X → All
Priority: -- → P2
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•