407053 - "Assertion failure: (cx)->requestDepth || (cx)->thread == (cx)->runtime->gcThread" with document.execCommand('copy', ...)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers:

Assertion failure: (cx)->requestDepth || (cx)->thread == (cx)->runtime->gcThread, at /Users/jruderman/trunk/mozilla/js/src/jsapi.c:5061

Stack trace:
  JS_Assert
  JS_InternString
  nsHTMLDocument::DoClipboardSecurityCheck
  nsHTMLDocument::ExecCommand
  NS_InvokeByIndex_P
  ...

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 291765 [details] [diff] [review]
v1

     JSContext *cx = nsnull;
     stack->Peek(&cx);
 
+    JSAutoRequest ar(cx);

We should have code here that makes sure cx is non-null, and probably return an error if it's null (to be on the safe side).

r+sr=jst with that.

Comment 3

[Johnny Stenback (:jst)]

Clearing blocker request as this already has approval.

Comment 4

[georgi - hopefully not receiving bugspam]

Attachment: another testcase - neterr1b.html

i can trigger this assertion/abort in another function with another testcase.

Assertion failure: (cx)->requestDepth || (cx)->thread == (cx)->runtime->gcThread, at firefox-cvs/mozilla/js/src/jsapi.c:4063
firefox-cvs/mozilla/fb-opt-static/dist/bin/run-mozilla.sh: line 131:  3051 Trace/breakpoint trap   "$prog" ${1+"$@"}

is this different bug?

Comment 5

[georgi - hopefully not receiving bugspam]

same assertion in JS_GetReservedSlot is Bug 410486

Comment 6

[Peter Van der Beken [:peterv]]

(In reply to comment #2)
> We should have code here that makes sure cx is non-null, and probably return an
> error if it's null (to be on the safe side).

Actually, I don't see why calling ExecCommand for the clipboard commands without JS on the stack should throw an error, so I'm making it return NS_OK if cx is null. Let me know if you disagree with that.

Comment 7

[Peter Van der Beken [:peterv]]

Checked in (with crashtest).