407078 - Unwanted blank lines on news.bbc.co.uk when text line is as wide as its container

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b2pre) Gecko/2007120319 Minefield/3.0b2pre ID:2007120319

1. New profile, start firefox
2. Go to http://news.bbc.co.uk/
3. Observe the text under "Other Top Stories" on the left hand side

If any of the stories' titles are as wide enough to stop at the edge of the webpage, then an unwanted blank line appears underneath.

No problem with: 20071203_0014_firefox-3.0b2pre.en-US.win32
Problems with: 20071203_0030_firefox-3.0b2pre.en-US.win32

Checkins to module PhoenixTinderbox between 2007-12-03 00:14 and 2007-12-03 00:29 : 
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1196669640&maxdate=1196670599

Due to bug 403426.

This bug description is really crappy, so please feel free to rewrite it. Also, a testcase would be a help ;-)

Comment 1

[Steve England [:stevee]]

Attachment: screenshot showing the unwanted blank lines

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Maybe fixed by bug 405577. I can't see the bug in a regular build on Mac, but then the testcase is pretty fragile.

Comment 3

[philippe (part-time)]

I can see the bug on Mac/10.4.11 if I zoom in (using Camino trunk: that is *text* zoom).

Comment 4

[Steve England [:stevee]]

(In reply to comment #2)
> Maybe fixed by bug 405577. I can't see the bug in a regular build on Mac, but
> then the testcase is pretty fragile.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b2pre) Gecko/2007120602 Minefield/3.0b2pre

I still see this problem, even after the landing of bug 405577.

Comment 5

[Martijn Wargers (dead)]

Attachment: testcase

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think here we're breaking before the <br> because it looks like any other non-text element.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Yeah, the problem is that we're breaking just before the <BR> which we should never do.

The patch here is very simple. We just suppress the trailing break from the nsLineBreaker when we're stopping because of a <BR>.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think we probably don't need to take this for beta2, but the patch is pretty safe so I could be convinced otherwise if it shows on the radar.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in