Closed Bug 407114 Opened 12 years ago Closed 12 years ago

when viewing the "Most Visited" item of the "Smart Bookmarks" folder in the places organizer, the "Visit Date" column is empty

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 3 beta3

People

(Reporter: moco, Assigned: mak)

References

Details

(Keywords: regression)

Attachments

(3 files, 1 obsolete file)

when viewing the "Most Visited" item of the "Smart Bookmarks" folder in the places organizer, the "Visit Date" column is empty

this is a regression from bug #399266, but I think it is acceptable.
with my test places original query was about 360ms
new query is about 3ms
this query (with visit_date) is about 8ms, probably acceptable, could you try with ispiked test file?
Attachment #291862 - Flags: review?(sspitzer)
that query looks good, and it performs well against the dreaded ispiked places.sqlite file.

but, I think we want to exclude certain visits when calculating the visit date.

something like:

SELECT h.id, h.url, h.title, h.rev_host, h.visit_count,
(SELECT MAX(visit_date) FROM moz_historyvisits WHERE place_id = h.id AND visit_type <> 4 AND visit_type <> 0), 
f.url, null, null 
FROM moz_places h
LEFT OUTER JOIN moz_favicons f ON h.favicon_id = f.id WHERE 
h.id IN (SELECT id FROM moz_places WHERE hidden <> 1 
ORDER BY visit_count DESC LIMIT 6 ) ORDER BY h.visit_count DESC

What do you think?
Assignee: nobody → mak77
Priority: -- → P2
Target Milestone: --- → Firefox 3 M11
Comment on attachment 291862 [details] [diff] [review]
add visit_date to most visited query

can you create a version that excludes embedded an null visits from the visit date sub-select?
Attachment #291862 - Flags: review?(sspitzer)
Attached patch updated patchSplinter Review
updated patch, remove my comment, add our friend Marco as a contributor to this code, and exclude embed and null visits.
Attachment #291862 - Attachment is obsolete: true
Comment on attachment 291957 [details] [diff] [review]
updated patch

r=sspitzer on marco's change, marco can you review my additional change?
Attachment #291957 - Flags: review+
Comment on attachment 291957 [details] [diff] [review]
updated patch

marco or dietrich, I'd take either one.
Attachment #291957 - Flags: review?(dietrich)
fine, i've tested it and there is no problem adding the check on visit_type, i get same timings. patch is good (thank you for credits)
Comment on attachment 291957 [details] [diff] [review]
updated patch

r=me
Attachment #291957 - Flags: review?(dietrich) → review+
Comment on attachment 291957 [details] [diff] [review]
updated patch

a=mconnor on behalf of drivers
Attachment #291957 - Flags: approval1.9? → approval1.9+
Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.212; previous revision: 1.211
done
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
verified with: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2007121904 Minefield/3.0b3pre and the equivalent Win XP build
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.