ECMA ed. 3 Object.prototype.hasOwnProperty sub-optimal for indexes

RESOLVED FIXED in M16

Status

()

Core
JavaScript Engine
P3
normal
RESOLVED FIXED
18 years ago
16 years ago

People

(Reporter: brendan, Assigned: brendan)

Tracking

({js1.5})

Trunk
js1.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

18 years ago
tag-able integer property ids, that is.  Patch coming up.

/be
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Keywords: js1.5
Target Milestone: --- → M16
(Assignee)

Comment 1

18 years ago
Created attachment 9206 [details] [diff] [review]
proposed fix
(Assignee)

Comment 2

18 years ago
Duh, not busted, just sub-optimal: property lookup must equate '2' to 2, e.g., 
so the patch is just a minor optimization to avoid making a string atom when a 
tagged-int property id will do.

/be
Summary: ECMA ed. 3 Object.prototype.hasOwnProperty busted for indexes → ECMA ed. 3 Object.prototype.hasOwnProperty sub-optimal for indexes
(Assignee)

Comment 3

18 years ago
Looking for r=.

/be
(Assignee)

Comment 4

18 years ago
Created attachment 9212 [details] [diff] [review]
better patch, no warning (unused atom removed)
(Assignee)

Comment 5

18 years ago
Roger, looking for r= and shaver jumped on a plane.  Thanks,

/be
(Assignee)

Comment 6

18 years ago
Fix checked in, I just know that shaver will approve (rogerl is on vacation till 
the 12th).

/be
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.