407327 - JSOP_DEFFUN: Optimizing js_CheckRedeclaration/OBJ_DEFINE_PROPERTY sequnce

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, enhancement)

Description

[Igor Bukanov]

Currently JSOP_DEFUN case in the interpreter calls js_CheckRedeclaration followed by OBJ_DEFINE_PROPERTY. Both calls will do a property lookup. It would be nice to combine both calls so the property lookup will be done only once.

Comment 1

[Brendan Eich [:brendan]]

OBJ_DEFINE_PROPERTY => js_DefineNativeProperty (via js_DefineProperty), but js_DefineNativeProperty calls js_LookupProperty iff a getter or setter is being defined, which can happen via JSOP_DEFFUN (top-level getter function foo(){}, etc. -- rare these days). Is this the lookup you mean, or just the scope search?

/be

Comment 2

[Igor Bukanov]

(In reply to comment #1)
> Is this the lookup you mean, or just the scope search?

I meant the scope search done by js_AddScopeProperty when js_DefineNativeProperty calls it.