Closed Bug 407369 Opened 17 years ago Closed 17 years ago

BrowserOnCommand() for Firefox netError page uses wrong location object

Categories

(Firefox :: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 3 beta3

People

(Reporter: kairo, Assigned: johnath)

References

Details

Attachments

(1 file)

As mentioned in bug 405862 comment #6 by gavin, bug 401575 added references to the wrong .location object in the BrowserOnCommand() handler for the Firefox netError pages, as it probably doesn't work right with a netError page that appears in a frame inside a website.
Flags: blocking-firefox3?
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Target Milestone: --- → Firefox 3 M11
Added extra context lines so that you can see the whole scope.
Attachment #292472 - Flags: review?(gavin.sharp)
Attachment #292472 - Flags: review?(gavin.sharp) → review+
Oops, accidentally submitted without the comment. Was just going to note for KaiRo's benefit that error page in frames don't currently work because of bug 399876, which I noticed while reviewing. This is still a desired and correct change, though.
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.911; previous revision: 1.910
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Blocks: 401575, 402207
No longer depends on: 401575
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: