407417 - Folder Icons in Places Organizer always appear open

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Eric Schwartz]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007120704 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007120704 Minefield/3.0b2pre

As per <https://litmus.mozilla.org/show_test.cgi?id=3990>, the folder icon of a closed folder should look closed.  The same icon appears for closed and open folders.

Reproducible: Always

Steps to Reproduce:
1. Open the Places manager
2. Click on the triangle next to a closed folder.
3. Observe the icon doesn't change.
4. Click on the triangle again.
5. Observe the icon doesn't change.
Actual Results:  
Icon doesn't appear "closed" when folder is closed.

Expected Results:  
Icon should appear closed when appropriate.

I like pie.

Comment 2

[Dietrich Ayala (:dietrich)]

hrm, on Mac the folder is always *closed*!!

Alex, are the icons already in place for these?

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

>Expected Results:  
>Icon should appear closed when appropriate.

This was probably mistakenly picked up on linux as we changed the behavior for OS X and Windows. As part of our effort to achieve visual integration with the surrounding desktop environment, we removed the open folder state for those two platforms.

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Folder icons for several gnome themes

This shows Nautilus vs. Firefox, we indeed do seem to using the open folder icon everywhere.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

Actually, in the case of glossy and mist, our extracted folder icon is strangely in between the open and closed states.  cc'ing Michael Ventnor since this deals with gtk icon upflift.

Comment 6

[Michael Ventnor]

Those programs are using the Freedesktop icon spec. We're not using that because we have no way of providing fallback, so we stick with the guaranteed GTK icon spec.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

>so we stick with the guaranteed GTK icon spec.

Does the guaranteed GTK icon spec have both open and closed states for folders, and are apps encouraged to use multiple folder states?

Comment 8

[Marco Bonardo [:mak]]

confirming because it's true, could be WONTFIX, comments are not clear about resolution.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

I don't actually know what the common behavior for Gnome is in terms of having an open/closed folder state.

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

The tree view in Nautilus 2.26.2 doesn't seem to have open states for the folders (tested with Mist and Human).  So perhaps wontfix?

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 12

[Marco Bonardo [:mak]]

no news here, let's continue with comment 10 plan.