make a copy of nsAccessibilityUtils

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

6.94 KB, patch
Aaron Leventhal
: review+
Mike Schroepfer
: approval1.9-
Details | Diff | Splinter Review
187 bytes, text/plain
Aaron Leventhal
: review+
Mike Schroepfer
: approval1.9-
Details
(Assignee)

Description

10 years ago
make a copy of files

original files:
accessible\src\base\nsAccessibilityUtils.h
accessible\src\base\nsAccessibilityUtils.cpp

destination file:
accessible\src\base\nsAccUtils.h
accessible\src\base\nsAccUtils.cpp

Original files won't be needed after coping. Should I put the patch now to use new files that will be checked in it simultaneously with file coping? Or is it preferable to file another bug where I remove old files and will use new files?
(Assignee)

Comment 1

10 years ago
We need to copy these files because nsAccessiblityUtils class has been renamed to nsAccUtils in bug 386922.
(Assignee)

Comment 2

10 years ago
Created attachment 292201 [details] [diff] [review]
use new files

use new files patch
Attachment #292201 - Flags: review?(aaronleventhal)
(In reply to comment #0)
> Original files won't be needed after coping. Should I put the patch now to use
> new files that will be checked in it simultaneously with file coping? Or is it
> preferable to file another bug where I remove old files and will use new files?

Since you already attached a patch to this bug, I would move this bug back to an a11y-related component, attach a cvscopy file there and get review on it, then file antoher cvs copy bug referencing the reviewed cvscopy file.
(Assignee)

Comment 4

10 years ago
How should cvscopy file look like and who should review it, accessibility peer?
(In reply to comment #4)
> How should cvscopy file look like and who should review it, accessibility peer?

See attachment 290895 [details] for an example, and yes, an a11y peer/owner should review it.
Basically, the file consists of lines of:
path/to/old/file path/to/new/file
(Assignee)

Comment 7

10 years ago
Created attachment 292207 [details]
cvs copy
(Assignee)

Updated

10 years ago
Attachment #292207 - Flags: review?(aaronleventhal)
Attachment #292207 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 292207 [details]
cvs copy

This is wrong. Need to use '/' instead of '\', and while you can start at accessible/, it is preferred that the cvscopy file start at mozilla/.
Attachment #292207 - Flags: review?(aaronleventhal) → review-
(Assignee)

Comment 9

10 years ago
Created attachment 292208 [details]
cvs copy

sorry. new cvscopy file.
Attachment #292207 - Attachment is obsolete: true
(Assignee)

Updated

10 years ago
Component: CVS: Copy → Disability Access APIs
Product: mozilla.org → Core
Version: other → Trunk
(Assignee)

Updated

10 years ago
Assignee: server-ops → aaronleventhal
QA Contact: justin → accessibility-apis
Comment on attachment 292208 [details]
cvs copy

This is better, but I doubt you meant to copy the same file twice. :)
(Assignee)

Updated

10 years ago
Attachment #292208 - Flags: review?(aaronleventhal)
Assignee: aaronleventhal → surkov.alexander
(Assignee)

Comment 11

10 years ago
Created attachment 292209 [details]
cvs copy

(In reply to comment #10)
> (From update of attachment 292208 [details])
> This is better, but I doubt you meant to copy the same file twice. :)
> 

thank you, I need to be more careful
Attachment #292208 - Attachment is obsolete: true
Attachment #292209 - Flags: review?(aaronleventhal)
Attachment #292208 - Flags: review?(aaronleventhal)

Updated

10 years ago
Attachment #292209 - Flags: review?(aaronleventhal) → review+

Comment 12

10 years ago
Why I are you doing this right now though? It conflicts with a big patch I have in bug 398910.

Updated

10 years ago
Attachment #292201 - Flags: review?(aaronleventhal) → review+
(Assignee)

Comment 13

10 years ago
(In reply to comment #12)
> Why I are you doing this right now though? It conflicts with a big patch I have
> in bug 398910.
> 

good question
1) I was aroung when introduced hypertext utils file, I remembered I wanted to rename it.
2) Previously it took a long time to copy files therefore I decided to start it now
3) I missed you patch banaly :)
(Assignee)

Updated

10 years ago
Attachment #292201 - Flags: approval1.9?
(Assignee)

Updated

10 years ago
Attachment #292209 - Flags: approval1.9?

Comment 14

10 years ago
Comment on attachment 292201 [details] [diff] [review]
use new files

Until you guys resolve comment 12
Attachment #292201 - Flags: approval1.9? → approval1.9-

Comment 15

10 years ago
Comment on attachment 292209 [details]
cvs copy

Until you guys resolve comment 12
Attachment #292209 - Flags: approval1.9? → approval1.9-
(Assignee)

Comment 16

10 years ago
fixed in bug 459973
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.